* [PATCH] perf inject: Convert comma to semicolon
@ 2024-07-16 7:53 Chen Ni
2024-07-16 13:33 ` Ian Rogers
2024-07-26 14:15 ` Arnaldo Carvalho de Melo
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2024-07-16 7:53 UTC (permalink / raw)
To: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
jolsa, irogers, adrian.hunter, kan.liang
Cc: linux-perf-users, linux-kernel, Chen Ni
Replace a comma between expression statements by a semicolon.
Fixes: 97406a7e4fa6 ("perf inject: Add support for injecting guest sideband events")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
tools/perf/builtin-inject.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index a212678d47be..7b4a5d56d279 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -2069,7 +2069,7 @@ static int __cmd_inject(struct perf_inject *inject)
*/
inject->tool.finished_init = host__finished_init;
/* Obey finished round ordering */
- inject->tool.finished_round = host__finished_round,
+ inject->tool.finished_round = host__finished_round;
/* Keep track of which CPU a VCPU is runnng on */
inject->tool.context_switch = host__context_switch;
/*
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf inject: Convert comma to semicolon
2024-07-16 7:53 [PATCH] perf inject: Convert comma to semicolon Chen Ni
@ 2024-07-16 13:33 ` Ian Rogers
2024-07-26 14:15 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 3+ messages in thread
From: Ian Rogers @ 2024-07-16 13:33 UTC (permalink / raw)
To: Chen Ni
Cc: peterz, mingo, acme, namhyung, mark.rutland, alexander.shishkin,
jolsa, adrian.hunter, kan.liang, linux-perf-users, linux-kernel
On Tue, Jul 16, 2024 at 12:55 AM Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Replace a comma between expression statements by a semicolon.
>
> Fixes: 97406a7e4fa6 ("perf inject: Add support for injecting guest sideband events")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/builtin-inject.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
> index a212678d47be..7b4a5d56d279 100644
> --- a/tools/perf/builtin-inject.c
> +++ b/tools/perf/builtin-inject.c
> @@ -2069,7 +2069,7 @@ static int __cmd_inject(struct perf_inject *inject)
> */
> inject->tool.finished_init = host__finished_init;
> /* Obey finished round ordering */
> - inject->tool.finished_round = host__finished_round,
> + inject->tool.finished_round = host__finished_round;
> /* Keep track of which CPU a VCPU is runnng on */
> inject->tool.context_switch = host__context_switch;
> /*
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf inject: Convert comma to semicolon
2024-07-16 7:53 [PATCH] perf inject: Convert comma to semicolon Chen Ni
2024-07-16 13:33 ` Ian Rogers
@ 2024-07-26 14:15 ` Arnaldo Carvalho de Melo
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2024-07-26 14:15 UTC (permalink / raw)
To: Chen Ni
Cc: peterz, mingo, namhyung, mark.rutland, alexander.shishkin, jolsa,
irogers, adrian.hunter, kan.liang, linux-perf-users, linux-kernel
On Tue, Jul 16, 2024 at 03:53:47PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Fixes: 97406a7e4fa6 ("perf inject: Add support for injecting guest sideband events")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Thanks, applied to tmp.perf-tools-next, again removed the fixes.
- Arnaldo
> ---
> tools/perf/builtin-inject.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
> index a212678d47be..7b4a5d56d279 100644
> --- a/tools/perf/builtin-inject.c
> +++ b/tools/perf/builtin-inject.c
> @@ -2069,7 +2069,7 @@ static int __cmd_inject(struct perf_inject *inject)
> */
> inject->tool.finished_init = host__finished_init;
> /* Obey finished round ordering */
> - inject->tool.finished_round = host__finished_round,
> + inject->tool.finished_round = host__finished_round;
> /* Keep track of which CPU a VCPU is runnng on */
> inject->tool.context_switch = host__context_switch;
> /*
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-26 14:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-16 7:53 [PATCH] perf inject: Convert comma to semicolon Chen Ni
2024-07-16 13:33 ` Ian Rogers
2024-07-26 14:15 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox