Linux Perf Users
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dapeng Mi <dapeng1.mi@intel.com>
Subject: Re: [Patch v2] perf tools: Fix incorrect --user-regs comments
Date: Wed, 28 May 2025 14:11:19 -0300	[thread overview]
Message-ID: <aDdDt9O1O4gky_st@x1> (raw)
In-Reply-To: <35efdc62-fc2b-40c7-9fbd-25fc6028fa6b@linux.intel.com>

On Wed, May 28, 2025 at 03:03:13PM +0800, Mi, Dapeng wrote:
> Kindly ping... Thanks.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> On 4/3/2025 2:08 PM, Dapeng Mi wrote:
> > The comment of "--user-regs" option is not correct, fix it.
> >
> > "on interrupt," -> "in user space,"
> >
> > Fixes: 84c417422798 ("perf record: Support direct --user-regs arguments")
> > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> > Reviewed-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/perf/builtin-record.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> > index ba20bf7c011d..d56273a0e241 100644
> > --- a/tools/perf/builtin-record.c
> > +++ b/tools/perf/builtin-record.c
> > @@ -3480,7 +3480,7 @@ static struct option __record_options[] = {
> >  		    "sample selected machine registers on interrupt,"
> >  		    " use '-I?' to list register names", parse_intr_regs),
> >  	OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",
> > -		    "sample selected machine registers on interrupt,"
> > +		    "sample selected machine registers in user space,"
> >  		    " use '--user-regs=?' to list register names", parse_user_regs),
> >  	OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
> >  		    "Record running/enabled time of read (:S) events"),
> >
> > base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc

      reply	other threads:[~2025-05-28 17:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03  6:08 [Patch v2] perf tools: Fix incorrect --user-regs comments Dapeng Mi
2025-05-28  7:03 ` Mi, Dapeng
2025-05-28 17:11   ` Arnaldo Carvalho de Melo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDdDt9O1O4gky_st@x1 \
    --to=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=irogers@google.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox