* [Patch v2] perf tools: Fix incorrect --user-regs comments
@ 2025-04-03 6:08 Dapeng Mi
2025-05-28 7:03 ` Mi, Dapeng
0 siblings, 1 reply; 3+ messages in thread
From: Dapeng Mi @ 2025-04-03 6:08 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Ian Rogers, Adrian Hunter, Alexander Shishkin,
Kan Liang
Cc: linux-perf-users, linux-kernel, Dapeng Mi, Dapeng Mi
The comment of "--user-regs" option is not correct, fix it.
"on interrupt," -> "in user space,"
Fixes: 84c417422798 ("perf record: Support direct --user-regs arguments")
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Reviewed-by: Ian Rogers <irogers@google.com>
---
tools/perf/builtin-record.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index ba20bf7c011d..d56273a0e241 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -3480,7 +3480,7 @@ static struct option __record_options[] = {
"sample selected machine registers on interrupt,"
" use '-I?' to list register names", parse_intr_regs),
OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",
- "sample selected machine registers on interrupt,"
+ "sample selected machine registers in user space,"
" use '--user-regs=?' to list register names", parse_user_regs),
OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
"Record running/enabled time of read (:S) events"),
base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch v2] perf tools: Fix incorrect --user-regs comments
2025-04-03 6:08 [Patch v2] perf tools: Fix incorrect --user-regs comments Dapeng Mi
@ 2025-05-28 7:03 ` Mi, Dapeng
2025-05-28 17:11 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Mi, Dapeng @ 2025-05-28 7:03 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Ian Rogers, Adrian Hunter, Alexander Shishkin,
Kan Liang
Cc: linux-perf-users, linux-kernel, Dapeng Mi
Kindly ping... Thanks.
On 4/3/2025 2:08 PM, Dapeng Mi wrote:
> The comment of "--user-regs" option is not correct, fix it.
>
> "on interrupt," -> "in user space,"
>
> Fixes: 84c417422798 ("perf record: Support direct --user-regs arguments")
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Reviewed-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/builtin-record.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> index ba20bf7c011d..d56273a0e241 100644
> --- a/tools/perf/builtin-record.c
> +++ b/tools/perf/builtin-record.c
> @@ -3480,7 +3480,7 @@ static struct option __record_options[] = {
> "sample selected machine registers on interrupt,"
> " use '-I?' to list register names", parse_intr_regs),
> OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",
> - "sample selected machine registers on interrupt,"
> + "sample selected machine registers in user space,"
> " use '--user-regs=?' to list register names", parse_user_regs),
> OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
> "Record running/enabled time of read (:S) events"),
>
> base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Patch v2] perf tools: Fix incorrect --user-regs comments
2025-05-28 7:03 ` Mi, Dapeng
@ 2025-05-28 17:11 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2025-05-28 17:11 UTC (permalink / raw)
To: Mi, Dapeng
Cc: Peter Zijlstra, Ingo Molnar, Namhyung Kim, Ian Rogers,
Adrian Hunter, Alexander Shishkin, Kan Liang, linux-perf-users,
linux-kernel, Dapeng Mi
On Wed, May 28, 2025 at 03:03:13PM +0800, Mi, Dapeng wrote:
> Kindly ping... Thanks.
Thanks, applied to perf-tools-next,
- Arnaldo
> On 4/3/2025 2:08 PM, Dapeng Mi wrote:
> > The comment of "--user-regs" option is not correct, fix it.
> >
> > "on interrupt," -> "in user space,"
> >
> > Fixes: 84c417422798 ("perf record: Support direct --user-regs arguments")
> > Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> > Reviewed-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/perf/builtin-record.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> > index ba20bf7c011d..d56273a0e241 100644
> > --- a/tools/perf/builtin-record.c
> > +++ b/tools/perf/builtin-record.c
> > @@ -3480,7 +3480,7 @@ static struct option __record_options[] = {
> > "sample selected machine registers on interrupt,"
> > " use '-I?' to list register names", parse_intr_regs),
> > OPT_CALLBACK_OPTARG(0, "user-regs", &record.opts.sample_user_regs, NULL, "any register",
> > - "sample selected machine registers on interrupt,"
> > + "sample selected machine registers in user space,"
> > " use '--user-regs=?' to list register names", parse_user_regs),
> > OPT_BOOLEAN(0, "running-time", &record.opts.running_time,
> > "Record running/enabled time of read (:S) events"),
> >
> > base-commit: 35d13f841a3d8159ef20d5e32a9ed3faa27875bc
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-28 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-03 6:08 [Patch v2] perf tools: Fix incorrect --user-regs comments Dapeng Mi
2025-05-28 7:03 ` Mi, Dapeng
2025-05-28 17:11 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox