* [PATCH v1] perf libunwind: Fix calls to thread__e_machine
@ 2026-02-11 5:38 Ian Rogers
2026-02-11 12:01 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2026-02-11 5:38 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, James Clark, linux-perf-users, linux-kernel
Add the missing e_flags option to fix the build.
Fixes: 4e66527f8859 ("perf thread: Add optional e_flags output argument to thread__e_machine")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/unwind-libunwind-local.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
index ecf0c01fe51f..5b39ce21e333 100644
--- a/tools/perf/util/unwind-libunwind-local.c
+++ b/tools/perf/util/unwind-libunwind-local.c
@@ -584,7 +584,9 @@ static int access_mem(unw_addr_space_t __maybe_unused as,
}
ret = perf_reg_value(&start, perf_sample__user_regs(ui->sample),
- perf_arch_reg_sp(thread__e_machine(ui->thread, ui->machine)));
+ perf_arch_reg_sp(thread__e_machine(ui->thread,
+ ui->machine,
+ /*e_flags=*/NULL)));
if (ret)
return ret;
@@ -733,7 +735,7 @@ static void _unwind__finish_access(struct maps *maps)
static int get_entries(struct unwind_info *ui, unwind_entry_cb_t cb,
void *arg, int max_stack)
{
- uint16_t e_machine = thread__e_machine(ui->thread, ui->machine);
+ uint16_t e_machine = thread__e_machine(ui->thread, ui->machine, /*e_flags=*/NULL);
u64 val;
unw_word_t ips[max_stack];
unw_addr_space_t addr_space;
--
2.53.0.239.g8d8fc8a987-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] perf libunwind: Fix calls to thread__e_machine
2026-02-11 5:38 [PATCH v1] perf libunwind: Fix calls to thread__e_machine Ian Rogers
@ 2026-02-11 12:01 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-02-11 12:01 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Namhyung Kim, Alexander Shishkin,
Jiri Olsa, Adrian Hunter, James Clark, linux-perf-users,
linux-kernel
On Tue, Feb 10, 2026 at 09:38:27PM -0800, Ian Rogers wrote:
> Add the missing e_flags option to fix the build.
>
> Fixes: 4e66527f8859 ("perf thread: Add optional e_flags output argument to thread__e_machine")
> Signed-off-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf-tools-next,
- Arnaldo
> ---
> tools/perf/util/unwind-libunwind-local.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
> index ecf0c01fe51f..5b39ce21e333 100644
> --- a/tools/perf/util/unwind-libunwind-local.c
> +++ b/tools/perf/util/unwind-libunwind-local.c
> @@ -584,7 +584,9 @@ static int access_mem(unw_addr_space_t __maybe_unused as,
> }
>
> ret = perf_reg_value(&start, perf_sample__user_regs(ui->sample),
> - perf_arch_reg_sp(thread__e_machine(ui->thread, ui->machine)));
> + perf_arch_reg_sp(thread__e_machine(ui->thread,
> + ui->machine,
> + /*e_flags=*/NULL)));
> if (ret)
> return ret;
>
> @@ -733,7 +735,7 @@ static void _unwind__finish_access(struct maps *maps)
> static int get_entries(struct unwind_info *ui, unwind_entry_cb_t cb,
> void *arg, int max_stack)
> {
> - uint16_t e_machine = thread__e_machine(ui->thread, ui->machine);
> + uint16_t e_machine = thread__e_machine(ui->thread, ui->machine, /*e_flags=*/NULL);
> u64 val;
> unw_word_t ips[max_stack];
> unw_addr_space_t addr_space;
> --
> 2.53.0.239.g8d8fc8a987-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-11 12:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-11 5:38 [PATCH v1] perf libunwind: Fix calls to thread__e_machine Ian Rogers
2026-02-11 12:01 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox