[PATCH 1/1] perf bench bpf: Add missing .gitignore file

[PATCH 1/1] perf bench bpf: Add missing .gitignore file

[Arnaldo Carvalho de Melo]

Hi Linus,

	I'll have this in the next pull req if you prefer not to merge
now,

- Arnaldo

---
From: Arnaldo Carvalho de Melo <acme@redhat.com>

In 713eeb2279402758 ("perf build: Move BPF skeleton generation out of
Makefile.perf") the bpf_skel used with 'perf bench uprobe' was moved
from tools/perf/util/bpf_skel/ to tools/perf/bench/bpf_skel.

Copy tools/perf/util/bpf_skel/.gitignore to that new directory so that
files generated during build get ignored by git.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Fixes: 713eeb2279402758 ("perf build: Move BPF skeleton generation out of Makefile.perf")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/bench/bpf_skel/.gitignore | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 tools/perf/bench/bpf_skel/.gitignore

diff --git a/tools/perf/bench/bpf_skel/.gitignore b/tools/perf/bench/bpf_skel/.gitignore
new file mode 100644
index 0000000000000000..cd01455e1b53c3d9
--- /dev/null
+++ b/tools/perf/bench/bpf_skel/.gitignore
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0-only
+.tmp
+*.skel.h
+vmlinux.h
-- 
2.54.0

Re: [PATCH 1/1] perf bench bpf: Add missing .gitignore file

[Namhyung Kim]

On Tue, Jun 23, 2026 at 09:05:30PM -0300, Arnaldo Carvalho de Melo wrote:
> Hi Linus,
> 
> 	I'll have this in the next pull req if you prefer not to merge
> now,
> 
> - Arnaldo
> 
> ---
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> In 713eeb2279402758 ("perf build: Move BPF skeleton generation out of
> Makefile.perf") the bpf_skel used with 'perf bench uprobe' was moved
> from tools/perf/util/bpf_skel/ to tools/perf/bench/bpf_skel.
> 
> Copy tools/perf/util/bpf_skel/.gitignore to that new directory so that
> files generated during build get ignored by git.
> 
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: James Clark <james.clark@linaro.org>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Fixes: 713eeb2279402758 ("perf build: Move BPF skeleton generation out of Makefile.perf")
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/bench/bpf_skel/.gitignore | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100644 tools/perf/bench/bpf_skel/.gitignore
> 
> diff --git a/tools/perf/bench/bpf_skel/.gitignore b/tools/perf/bench/bpf_skel/.gitignore
> new file mode 100644
> index 0000000000000000..cd01455e1b53c3d9
> --- /dev/null
> +++ b/tools/perf/bench/bpf_skel/.gitignore
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +.tmp
> +*.skel.h
> +vmlinux.h

I think it's enough to add '*.skel.h' only as other files are still
under util/bpf_skel.  But having others would not be harmful.

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

Re: [PATCH 1/1] perf bench bpf: Add missing .gitignore file

[Arnaldo Carvalho de Melo]

On Tue, Jun 23, 2026 at 05:27:38PM -0700, Namhyung Kim wrote:
> On Tue, Jun 23, 2026 at 09:05:30PM -0300, Arnaldo Carvalho de Melo wrote:
> > +++ b/tools/perf/bench/bpf_skel/.gitignore
> > @@ -0,0 +1,4 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +.tmp
> > +*.skel.h
> > +vmlinux.h
 
> I think it's enough to add '*.skel.h' only as other files are still
> under util/bpf_skel.  But having others would not be harmful.
 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

⬢ [acme@toolbx perf-tools]$ ls -la tools/perf/bench/bpf_skel/.tmp
total 8
drwxr-xr-x. 1 acme acme   36 Jun 23 21:01 .
drwxr-xr-x. 1 acme acme  102 Jun 23 21:01 ..
-rw-r--r--. 1 acme acme 7840 Jun 23 21:01 bench_uprobe.bpf.o
⬢ [acme@toolbx perf-tools]$ 

.tmp is created as well.

- Arnaldo

Re: [PATCH 1/1] perf bench bpf: Add missing .gitignore file

[Linus Torvalds]

On Tue, 23 Jun 2026 at 17:32, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> .tmp is created as well.

Note that the top-level .gitignore makes sure that we ignore any
dot-files by default (along with a lot of the usual patterns, of
course - not just object files, but various other binary file
endings).

( Yes, gitignore files do allow overrides to "un-ignore" files too,
but almost nobody ever uses that, there's seldom any reason for some
top-level file to say "ignore all generated files of this pattern" and
then a subdirectory gitignore says "but not this pattern". Some crazy
directories do say "ignore everything" and then they explicitly
unignore some patterns, but honestly, that's a mark of a diseased mind
)

                Linus

Re: [PATCH 1/1] perf bench bpf: Add missing .gitignore file

[Arnaldo Carvalho de Melo]

On Tue, Jun 23, 2026 at 05:42:58PM -0700, Linus Torvalds wrote:
> On Tue, 23 Jun 2026 at 17:32, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > .tmp is created as well.
> 
> Note that the top-level .gitignore makes sure that we ignore any
> dot-files by default (along with a lot of the usual patterns, of
> course - not just object files, but various other binary file
> endings).
> 
> ( Yes, gitignore files do allow overrides to "un-ignore" files too,
> but almost nobody ever uses that, there's seldom any reason for some
> top-level file to say "ignore all generated files of this pattern" and
> then a subdirectory gitignore says "but not this pattern". Some crazy
> directories do say "ignore everything" and then they explicitly
> unignore some patterns, but honestly, that's a mark of a diseased mind
> )

Yeah, but having .tmp there its kinda like not depending on having the
prototype for a function indirectly obtained via some include chain, by
luck, having .tmp there documents that that thing is (or a strong maybe,
in the case of vmlinux.h) generated there and should be ignored.

Anyway, now it is ignored, doubly so in the case of .tmp.

- Arnaldo