Linux Perf Users
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: sashiko-reviews@lists.linux.dev
Cc: Ian Rogers <irogers@google.com>, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v13 1/3] dt-bindings: perf: Add Broadcom Raspberry Pi AXI PMU definition
Date: Sat, 15 Aug 2026 23:39:42 +0200	[thread overview]
Message-ID: <aoDZrWaC20bfc2jX@monoceros> (raw)
In-Reply-To: <20260815173050.041A61F000E9@smtp.kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

On Sat, Aug 15, 2026 at 05:30:49PM +0000, sashiko-bot@kernel.org wrote:
> > Add Device Tree bindings for the Broadcom AXI PMU hardware blocks present
> > in the Raspberry Pi SoC line (BCM2835, BCM2711, BCM2712).
> > 
> > Depending on the SoC and security configuration, these PMUs support either
> > direct MMIO access or routing via the Raspberry Pi firmware Mailbox IPC.
> > The bindings support defining 1 or 2 backing MMIO regions natively map
> > the system and VPU control surfaces.
> > 
> > Assisted-by: Antigravity:gemini-3.6-flash
> > Signed-off-by: Ian Rogers <irogers@google.com>
> 
> Sashiko has reviewed this patch and found no issues. It looks great!

While Sashiko doesn't find issues any more, checkpatch still does. It
(rightfully!) criticizes usage of LINUX_VERSION_CODE which is unsuitable
for mainline inclusion.

Florian already pointed that out in reply to v10 or v11 (these two
versions were not marked with a vX and I don't feel like doing the
detective work to find that out. Usually you can see that using the Date
they were sent, but they were sent on the same day and both in reply to
v9 (which was also sent the same day 🙄)). Sad Ian knew better and
continued using LINUX_VERSION_CODE. :-(

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-08-15 21:39 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  8:38 [PATCH v1 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-11  8:38 ` [PATCH v1 1/2] perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-11 14:32   ` Uwe Kleine-König
2026-08-11  8:38 ` [PATCH v1 2/2] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-11 23:51 ` [PATCH v2 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-11 23:51   ` [PATCH v2 1/2] perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-12  0:04     ` sashiko-bot
2026-08-11 23:51   ` [PATCH v2 2/2] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-12  0:05     ` sashiko-bot
2026-08-12  0:27   ` [PATCH v3 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-12  0:27     ` [PATCH v3 1/2] perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-12  0:40       ` sashiko-bot
2026-08-12  0:27     ` [PATCH v3 2/2] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-12  0:40       ` sashiko-bot
2026-08-12  5:24     ` [PATCH v4 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-12  5:24       ` [PATCH v4 1/2] perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-12  5:36         ` sashiko-bot
2026-08-12  5:24       ` [PATCH v4 2/2] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-12  5:34         ` sashiko-bot
2026-08-12  8:27       ` [PATCH v4 0/2] perf: Add Raspberry Pi AXI PMU driver Will Deacon
2026-08-12 13:38         ` Ian Rogers
2026-08-12 16:26           ` Uwe Kleine-König
2026-08-12 21:37             ` Ian Rogers
2026-08-13  6:59               ` Uwe Kleine-König
2026-08-13  8:41           ` Will Deacon
2026-08-13 13:44             ` Ian Rogers
2026-08-13 15:01               ` Uwe Kleine-König
2026-08-13  9:08         ` Peter Robinson
2026-08-13 13:48           ` Ian Rogers
2026-08-13 16:34             ` Florian Fainelli
2026-08-13 17:56               ` Ian Rogers
2026-08-12 23:01       ` [PATCH v5 " Ian Rogers
2026-08-12 23:01         ` [PATCH v5 1/2] perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-12 23:15           ` sashiko-bot
2026-08-12 23:01         ` [PATCH v5 2/2] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-12 23:18           ` sashiko-bot
2026-08-12 23:07         ` [PATCH v5 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-12 23:07         ` Ian Rogers
2026-08-12 23:07           ` [PATCH v5 1/2] perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-12 23:25             ` sashiko-bot
2026-08-13  0:06             ` Florian Fainelli
2026-08-12 23:08           ` [PATCH v5 2/2] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-12 23:24             ` sashiko-bot
2026-08-13  4:35         ` [PATCH v6 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-13  4:35           ` [PATCH v6 1/2] perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-13  4:48             ` sashiko-bot
2026-08-13  4:35           ` [PATCH v6 2/2] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-13  4:43             ` sashiko-bot
2026-08-13  5:24           ` [PATCH v7 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-13  5:24             ` [PATCH v7 1/2] perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-13  5:35               ` sashiko-bot
2026-08-13  5:24             ` [PATCH v7 2/2] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-13  5:46               ` sashiko-bot
2026-08-13  6:42             ` [PATCH v8 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-13  6:42               ` [PATCH v8 1/2] perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-13  6:51                 ` sashiko-bot
2026-08-13  6:42               ` [PATCH v8 2/2] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-13  6:52                 ` sashiko-bot
2026-08-13  7:30               ` [PATCH v9 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-13  7:30                 ` perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-13  7:40                   ` sashiko-bot
2026-08-13 17:31                   ` Florian Fainelli
2026-08-15  6:19                     ` Ian Rogers
2026-08-13  7:30                 ` perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-13  8:03                 ` [PATCH v10 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-13  8:03                 ` perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-13  8:13                   ` sashiko-bot
2026-08-13  8:03                 ` perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-13 14:26                 ` [PATCH v11 0/2] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-13 14:26                 ` perf: Add Raspberry Pi BCM2835 " Ian Rogers
2026-08-13 14:38                   ` sashiko-bot
2026-08-13 14:26                 ` perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-15  8:20                 ` [PATCH v12 0/3] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-15  8:20                   ` [PATCH v12 1/3] dt-bindings: perf: Add Broadcom Raspberry Pi AXI PMU definition Ian Rogers
2026-08-15  8:25                     ` sashiko-bot
2026-08-15  8:20                   ` [PATCH v12 2/3] perf: Add Raspberry Pi BCM2835 AXI PMU driver Ian Rogers
2026-08-15  8:30                     ` sashiko-bot
2026-08-15  8:20                   ` [PATCH v12 3/3] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-15  8:33                     ` sashiko-bot
2026-08-15 17:27                   ` [PATCH v13 0/3] perf: Add Raspberry Pi AXI PMU driver Ian Rogers
2026-08-15 17:27                     ` [PATCH v13 1/3] dt-bindings: perf: Add Broadcom Raspberry Pi AXI PMU definition Ian Rogers
2026-08-15 17:30                       ` sashiko-bot
2026-08-15 21:39                         ` Uwe Kleine-König [this message]
2026-08-15 17:27                     ` [PATCH v13 2/3] perf: Add Raspberry Pi BCM2835 AXI PMU driver Ian Rogers
2026-08-15 17:35                       ` sashiko-bot
2026-08-15 17:27                     ` [PATCH v13 3/3] perf: Add Raspberry Pi 5 (BCM2712) AXI PMU support Ian Rogers
2026-08-15 17:38                       ` sashiko-bot
2026-08-15 18:40                     ` [PATCH v13 0/3] perf: Add Raspberry Pi AXI PMU driver Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoDZrWaC20bfc2jX@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox