Linux Perf Users
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Gennady Kupava <gennady.kupava@gmail.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [DISCUSSION] Three problems behind broken "perf --call-graph dwarf" on AMD: IP and stack dump mismatch, libdw fails on lld's layout, and the unwinder fallback never runs
Date: Fri, 28 Aug 2026 09:58:47 -0700	[thread overview]
Message-ID: <apG-RzV0zyjoC-FY@google.com> (raw)
In-Reply-To: <apCyQ93c48Dy4H-S@google.com>

On Thu, Aug 27, 2026 at 02:55:15PM -0700, Namhyung Kim wrote:
> Hello,
> 
> Thanks a lot for your detailed report!  It's good but let me jump into
> the action items directly.
> 
> On Fri, Aug 21, 2026 at 10:49:59PM +0100, Gennady Kupava wrote:
[SNIP]
> > 2. perf: precise events and DWARF call graphs are mutually exclusive on this
> >    hardware, so arguably perf should simply not let the two be combined.  I
> >    would suggest two rules rather than one, because a blanket refusal would
> >    make the common case worse:
> > 
> >    - for the default event, drop the P when --call-graph dwarf is requested,
> >      silently and on PMUs where precision means IBS.  Otherwise a plain
> >      "perf record -g --call-graph dwarf" starts failing outright on every AMD
> >      box, which is worse than today.  The s390 case in evlist.c suggests this
> >      kind of substitution is considered acceptable;
> > 
> >    - if the user asked for a precise event explicitly and also asked for
> >      DWARF call chains, refuse with a message that says why and what to do,
> >      instead of quietly producing a useless result.
> > 
> >    Note that this should be scoped to IBS.  On Intel, PEBS records the whole
> >    register set, so precise events and DWARF unwinding work together there
> >    and nothing needs restricting.  Frame-pointer call graphs are also fine
> >    with precise events - only the leaf frame is off.
> 
> I think we can enable both precise IP and dwarf callchains by using
> PERF_SAMPLE_REGS_INTR.  For unwinding, it should use PERF_REG_X86_IP
> from the REGS_INTR instead of sample.ip

Ok, it seems we already do this in the perf tools but it looks like the
kernel already overwrote the PERF_REG_X86_IP with the precise IP.  I
feel like we should fix the kernel.

Thanks,
Namhyung


  parent reply	other threads:[~2026-08-28 16:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 21:49 [DISCUSSION] Three problems behind broken "perf --call-graph dwarf" on AMD: IP and stack dump mismatch, libdw fails on lld's layout, and the unwinder fallback never runs Gennady Kupava
2026-08-24 13:35 ` Ravi Bangoria
2026-08-25 18:05 ` Ian Rogers
2026-08-27 21:55 ` Namhyung Kim
2026-08-28 16:47   ` Namhyung Kim
2026-08-28 16:58   ` Namhyung Kim [this message]
2026-08-31  5:05     ` Ravi Bangoria
2026-09-01 15:19       ` Namhyung Kim
2026-09-03  8:39         ` Mi, Dapeng
2026-09-03 11:36           ` Ravi Bangoria
2026-09-03 11:59             ` Mi, Dapeng
2026-09-03 16:02               ` Ravi Bangoria
2026-09-04  0:22                 ` Mi, Dapeng
2026-09-05 10:14                   ` Gennady Kupava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apG-RzV0zyjoC-FY@google.com \
    --to=namhyung@kernel.org \
    --cc=gennady.kupava@gmail.com \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox