Linux Perf Users
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiebin Sun <jiebin.sun@intel.com>
Cc: sashiko-reviews@lists.linux.dev, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 4/4] perf tests c2c: Add function view stdio coverage
Date: Fri, 25 Sep 2026 15:27:47 +0200	[thread overview]
Message-ID: <arZ200WZAtBYy5bb@x2> (raw)
In-Reply-To: <20260909030156.1771188-1-jiebin.sun@intel.com>

On Wed, Sep 09, 2026 at 11:01:52AM +0800, Jiebin Sun wrote:
> Hi Arnaldo,
> 
> Thanks for checking this.
> 
> Patch 2/4 covers this case:
> 
>   perf tests c2c: Report skip when the workload fails
> 
> It sets err=2 before returning when the workload fails, while patch 4 calls
> test_c2c_function_report() only when err remains 0.
> 
> I also verified this by forcing the workload command to fail. The script
> printed the skip message, did not run the function test, and exited with
> status 2, which the perf test harness treats as a skip.
> 
> So I don't think any change is needed here.

Thanks for checking, applied to perf-tools-next, for v7.4.

- Arnaldo

  reply	other threads:[~2026-09-25 13:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  5:56 [PATCH 0/4] perf c2c: Add function-view stdio support and coverage Jiebin Sun
2026-08-21  5:56 ` [PATCH 1/4] perf c2c: Fix documented default coalesce fields Jiebin Sun
2026-08-21  5:57   ` sashiko-bot
2026-08-21  5:56 ` [PATCH 2/4] perf tests c2c: Report skip when the workload fails Jiebin Sun
2026-08-21  5:52   ` sashiko-bot
2026-08-21  5:56 ` [PATCH 3/4] perf c2c: Add stdio support for the function view Jiebin Sun
2026-08-21  5:58   ` sashiko-bot
2026-08-21  5:56 ` [PATCH 4/4] perf tests c2c: Add function view stdio coverage Jiebin Sun
2026-08-21  5:58   ` sashiko-bot
2026-09-08 21:22     ` Arnaldo Carvalho de Melo
2026-09-09  3:01       ` Jiebin Sun
2026-09-25 13:27         ` Arnaldo Carvalho de Melo [this message]
2026-08-29 20:05 ` [PATCH 0/4] perf c2c: Add function-view stdio support and coverage Namhyung Kim
2026-08-29 22:51   ` Arnaldo Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arZ200WZAtBYy5bb@x2 \
    --to=acme@kernel.org \
    --cc=jiebin.sun@intel.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox