Linux Perf Users
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: sashiko-reviews@lists.linux.dev, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 1/2] perf tests: Assign return value of ioctl in wp_modify test
Date: Sun, 8 Nov 2026 20:54:10 -0800	[thread overview]
Message-ID: <avFR8t2S7Q0ZeKqB@z2> (raw)
In-Reply-To: <79708703-7e59-315b-04f6-9d24a694eece@loongson.cn>

On Fri, Nov 06, 2026 at 05:51:35PM +0800, Tiezhu Yang wrote:
> On 11/6/26 5:36 PM, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential
> > issue to consider:
> 
> ...
> 
> > [Severity: Low]
> > This fixes a missing return value assignment introduced when the
> > watchpoint test was added.  Should the commit message include a Fixes
> > tag?
> > 
> >    Fixes: 2e85d5979e8d ("perf test: Add watchpoint test")
> 
> This is just a simple test case fix, so I'll let the maintainers
> decide if a Fixes tag is necessary when applying the patch.

Yep, I'll add this.

Thanks,
Namhyung


  reply	other threads:[~2026-11-09  4:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  9:28 [PATCH v1 0/2] perf tests: Fix and improve watchpoint tests Tiezhu Yang
2026-11-06  9:28 ` [PATCH v1 1/2] perf tests: Assign return value of ioctl in wp_modify test Tiezhu Yang
2026-11-06  9:36   ` sashiko-bot
2026-11-06  9:51     ` Tiezhu Yang
2026-11-09  4:54       ` Namhyung Kim [this message]
2026-11-06  9:28 ` [PATCH v1 2/2] perf tests: Use TEST_ASSERT_EQUAL for all watchpoint tests Tiezhu Yang
2026-11-06  9:34   ` sashiko-bot
2026-11-10  2:52 ` [PATCH v1 0/2] perf tests: Fix and improve " Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avFR8t2S7Q0ZeKqB@z2 \
    --to=namhyung@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox