* [PATCH] perf/core: Skip empty AUX records with only format flags
@ 2026-08-25 10:37 Leo Yan
2026-08-25 10:44 ` sashiko-bot
2026-08-26 8:52 ` James Clark
0 siblings, 2 replies; 3+ messages in thread
From: Leo Yan @ 2026-08-25 10:37 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Ian Rogers, Adrian Hunter, James Clark, Suzuki K Poulose,
Tamas Petz, Tamas Zsoldos
Cc: linux-perf-users, linux-kernel, Leo Yan
perf_aux_output_end() emits a PERF_RECORD_AUX when the recorded size is
nonzero or when any flag other than PERF_AUX_FLAG_OVERWRITE is set.
PMU format flags describe how an AUX payload is encoded. TRBE driver
sets PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW for raw trace buffers, causing
an AUX record to be emitted even when no trace data.
This is noticeable when tracing a task with strace. Ptrace stops
repeatedly end empty AUX transactions, producing many zero-sized
PERF_RECORD_AUX records. For example:
perf record -e cs_etm//u -m,128M -- strace ls
perf script -D 2>&1 |
awk '/PERF_RECORD_AUX offset/ {
for (i = 1; i <= NF; i++)
if ($i == "size:" && $(i + 1) == "0")
count++
}
END { print count }'
165
This recording contains 165 zero-sized AUX records which provide no
useful information to userspace.
Ignore PERF_AUX_FLAG_PMU_FORMAT_TYPE_MASK, together with
PERF_AUX_FLAG_OVERWRITE, when deciding whether an empty AUX record is
useful. Zero-sized records carrying TRUNCATED, PARTIAL or COLLISION
are still emitted.
Fixes: 547b60988e63 ("perf: aux: Add flags for the buffer format")
Reported-by: Tamas Petz <tamas.petz@arm.com>
Signed-off-by: Leo Yan <leo.yan@arm.com>
---
kernel/events/ring_buffer.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c
index 9fe92161715e0987520cddb873dd162fd2a77d5c..1b1ffe0533e58a9d976d0eb0fc23e09d5936da2b 100644
--- a/kernel/events/ring_buffer.c
+++ b/kernel/events/ring_buffer.c
@@ -509,7 +509,10 @@ void perf_aux_output_end(struct perf_output_handle *handle, unsigned long size)
/*
* Only send RECORD_AUX if we have something useful to communicate
*
- * Note: the OVERWRITE records by themselves are not considered
+ * PMU_FORMAT bits identify the PMU type rather than an AUX event
+ * has occurred, so ignore them for zero-sized records.
+ *
+ * The OVERWRITE records by themselves are not considered
* useful, as they don't communicate any *new* information,
* aside from the short-lived offset, that becomes history at
* the next event sched-in and therefore isn't useful.
@@ -518,7 +521,9 @@ void perf_aux_output_end(struct perf_output_handle *handle, unsigned long size)
* offset. So, from now on we don't output AUX records that
* have *only* OVERWRITE flag set.
*/
- if (size || (handle->aux_flags & ~(u64)PERF_AUX_FLAG_OVERWRITE))
+ if (size ||
+ (handle->aux_flags & ~(u64)(PERF_AUX_FLAG_PMU_FORMAT_TYPE_MASK |
+ PERF_AUX_FLAG_OVERWRITE)))
perf_event_aux_event(handle->event, aux_head, size,
handle->aux_flags);
---
base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91
change-id: 20260825-perf_core_fix_zero_aux_records-8873172d2596
Best regards,
--
Leo Yan <leo.yan@arm.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/core: Skip empty AUX records with only format flags
2026-08-25 10:37 [PATCH] perf/core: Skip empty AUX records with only format flags Leo Yan
@ 2026-08-25 10:44 ` sashiko-bot
2026-08-26 8:52 ` James Clark
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-08-25 10:44 UTC (permalink / raw)
To: Leo Yan; +Cc: linux-perf-users
> perf_aux_output_end() emits a PERF_RECORD_AUX when the recorded size is
> nonzero or when any flag other than PERF_AUX_FLAG_OVERWRITE is set.
>
> PMU format flags describe how an AUX payload is encoded. TRBE driver
> sets PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW for raw trace buffers, causing
> an AUX record to be emitted even when no trace data.
>
> This is noticeable when tracing a task with strace. Ptrace stops
> repeatedly end empty AUX transactions, producing many zero-sized
> PERF_RECORD_AUX records. For example:
>
> perf record -e cs_etm//u -m,128M -- strace ls
>
> perf script -D 2>&1 |
> awk '/PERF_RECORD_AUX offset/ {
> [ ... ]
> are still emitted.
>
> Fixes: 547b60988e63 ("perf: aux: Add flags for the buffer format")
> Reported-by: Tamas Petz <tamas.petz@arm.com>
> Signed-off-by: Leo Yan <leo.yan@arm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260825-perf_core_fix_zero_aux_records-v1-1-23b95e8d5df3@arm.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/core: Skip empty AUX records with only format flags
2026-08-25 10:37 [PATCH] perf/core: Skip empty AUX records with only format flags Leo Yan
2026-08-25 10:44 ` sashiko-bot
@ 2026-08-26 8:52 ` James Clark
1 sibling, 0 replies; 3+ messages in thread
From: James Clark @ 2026-08-26 8:52 UTC (permalink / raw)
To: Leo Yan
Cc: linux-perf-users, linux-kernel, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Ian Rogers, Adrian Hunter,
Suzuki K Poulose, Tamas Petz, Tamas Zsoldos
On 25/08/2026 11:37, Leo Yan wrote:
> perf_aux_output_end() emits a PERF_RECORD_AUX when the recorded size is
> nonzero or when any flag other than PERF_AUX_FLAG_OVERWRITE is set.
>
> PMU format flags describe how an AUX payload is encoded. TRBE driver
> sets PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW for raw trace buffers, causing
> an AUX record to be emitted even when no trace data.
>
> This is noticeable when tracing a task with strace. Ptrace stops
> repeatedly end empty AUX transactions, producing many zero-sized
> PERF_RECORD_AUX records. For example:
>
> perf record -e cs_etm//u -m,128M -- strace ls
>
> perf script -D 2>&1 |
> awk '/PERF_RECORD_AUX offset/ {
> for (i = 1; i <= NF; i++)
> if ($i == "size:" && $(i + 1) == "0")
> count++
> }
> END { print count }'
> 165
>
> This recording contains 165 zero-sized AUX records which provide no
> useful information to userspace.
>
> Ignore PERF_AUX_FLAG_PMU_FORMAT_TYPE_MASK, together with
> PERF_AUX_FLAG_OVERWRITE, when deciding whether an empty AUX record is
> useful. Zero-sized records carrying TRUNCATED, PARTIAL or COLLISION
> are still emitted.
>
> Fixes: 547b60988e63 ("perf: aux: Add flags for the buffer format")
> Reported-by: Tamas Petz <tamas.petz@arm.com>
> Signed-off-by: Leo Yan <leo.yan@arm.com>
> ---
> kernel/events/ring_buffer.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c
> index 9fe92161715e0987520cddb873dd162fd2a77d5c..1b1ffe0533e58a9d976d0eb0fc23e09d5936da2b 100644
> --- a/kernel/events/ring_buffer.c
> +++ b/kernel/events/ring_buffer.c
> @@ -509,7 +509,10 @@ void perf_aux_output_end(struct perf_output_handle *handle, unsigned long size)
> /*
> * Only send RECORD_AUX if we have something useful to communicate
> *
> - * Note: the OVERWRITE records by themselves are not considered
> + * PMU_FORMAT bits identify the PMU type rather than an AUX event
> + * has occurred, so ignore them for zero-sized records.
> + *
> + * The OVERWRITE records by themselves are not considered
> * useful, as they don't communicate any *new* information,
> * aside from the short-lived offset, that becomes history at
> * the next event sched-in and therefore isn't useful.
> @@ -518,7 +521,9 @@ void perf_aux_output_end(struct perf_output_handle *handle, unsigned long size)
> * offset. So, from now on we don't output AUX records that
> * have *only* OVERWRITE flag set.
> */
> - if (size || (handle->aux_flags & ~(u64)PERF_AUX_FLAG_OVERWRITE))
> + if (size ||
> + (handle->aux_flags & ~(u64)(PERF_AUX_FLAG_PMU_FORMAT_TYPE_MASK |
> + PERF_AUX_FLAG_OVERWRITE)))
Almost seems like it would be better to define the union of what's
considered useful where they are defined in perf_event.h. Or invert it
here and do (TRUNCATED | PARTIAL etc). Otherwise the same thing will
happen when the next thing is added.
Other than that:
Reviewed-by: James Clark <james.clark@linaro.org>
> perf_event_aux_event(handle->event, aux_head, size,
> handle->aux_flags);
>
>
> ---
> base-commit: 66498c75b4f8017f62d720d9b59675bdf3abce91
> change-id: 20260825-perf_core_fix_zero_aux_records-8873172d2596
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-26 8:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-25 10:37 [PATCH] perf/core: Skip empty AUX records with only format flags Leo Yan
2026-08-25 10:44 ` sashiko-bot
2026-08-26 8:52 ` James Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox