Re: [PATCH perf-tools-next v10 04/10] perf ftrace: Add basic task call stack management

[sashiko-bot@kernel.org]

> The function_graph tracer records kernel function entries and exits with
> nested indentation. To perform call graph analysis and subsequent inlined
> function reconstruction, userspace must track the active call stack on a
> per-task and per-CPU basis.
> 
> Introduce basic call stack management for the function graph tracer:
> 
>     1.  Data structures
> 
>         Define struct ftrace_stack_frame to track function names,
>         indentation, and inlined status.
> 
>         Define struct ftrace_task_state with a dynamically resisable call
>         stack array, tracked in a hash table keyed by PID alongside per-CPU
>         active task bindings (ftrace_cpu_tasks).
> [ ... ]
>         Stream complete trace lines through ftrace_process_fgraph_line()
>         in __cmd_ftrace() and clean up allocated CPU states on exit via
>         ftrace_cpu_states__clear().
> 
> Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024212549.450634-1-atomlin@atomlin.com?part=4