Re: [PATCH perf-tools-next v10 10/10] perf ftrace: Filter extraneous functions in function graph tracer

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf ftrace: duplicate struct members seq and min_raw_indent break build
--

commit f4f59c9c42f809fa549a2f95e0003511775c0575
Author: Aaron Tomlin <atomlin@atomlin.com>

perf ftrace: Filter extraneous functions in function graph tracer

This commit adds userspace callgraph state tracking and return-address
validation to perf ftrace to suppress top-level non-target functions and
detached orphan calls when tracing with function_graph target filters (-G).

> diff --git a/tools/perf/util/ftrace.c b/tools/perf/util/ftrace.c
> index 72c3fddd93bce..ab8300602fa8a 100644
> --- a/tools/perf/util/ftrace.c
> +++ b/tools/perf/util/ftrace.c

[ ... ]

> @@ -48,9 +49,16 @@ struct ftrace_task_state {
>  	int max_stack;
>  	int depth;
>  	int inlined_depth;
> -	int overflow_depth;
>  	u64 seq;
>  	int min_raw_indent;
> +	u64 seq;
> +	int min_raw_indent;

[Severity: Low]
Does this break the build when compiling tools/perf/util/ftrace.c?

In struct ftrace_task_state, the members seq and min_raw_indent are already
declared immediately above, so adding them a second time causes compilation
to fail with duplicate struct member errors. Should the duplicate seq and
min_raw_indent declarations be removed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024212549.450634-1-atomlin@atomlin.com?part=10