* [PATCH v1] perf jevents: Don't encode MSRs with no value
@ 2026-11-05 4:48 Ian Rogers
2026-11-05 4:53 ` sashiko-bot
2026-11-05 5:42 ` Mi, Dapeng
0 siblings, 2 replies; 3+ messages in thread
From: Ian Rogers @ 2026-11-05 4:48 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Jiri Olsa, Ian Rogers, Adrian Hunter, James Clark,
Dapeng Mi, Edward Baker, Thomas Falcon, Perry Taylor,
linux-perf-users, linux-kernel
Cc: kernel test robot
Fixes the events mem_trans_retired.load_latency (EMR) and
mem_inst_retired.latency_above_threshold_0 (NHM, WSM) that were having
their ldlat= value encoded as python's None.
Fixes: ffc606ada3d7 ("perf jevents: Add python converter script")
Reported-by: kernel test robot <yi1.lai@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202611050801.67bb4af4-lkp@intel.com
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/pmu-events/jevents.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
index 080e04b51b8c..e083f7495e67 100755
--- a/tools/perf/pmu-events/jevents.py
+++ b/tools/perf/pmu-events/jevents.py
@@ -396,7 +396,7 @@ class JsonEvent:
event += f',{value}{canonicalize_value(jd[key])}'
if filter:
event += f',{filter}'
- if msr:
+ if msr and msrval:
event += f',{msr}{msrval}'
if self.desc and extra_desc:
self.desc += extra_desc
--
2.56.0.455.g6c5a503b38-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf jevents: Don't encode MSRs with no value
2026-11-05 4:48 [PATCH v1] perf jevents: Don't encode MSRs with no value Ian Rogers
@ 2026-11-05 4:53 ` sashiko-bot
2026-11-05 5:42 ` Mi, Dapeng
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-11-05 4:53 UTC (permalink / raw)
To: Ian Rogers, linux-perf-users
> Fixes the events mem_trans_retired.load_latency (EMR) and
> mem_inst_retired.latency_above_threshold_0 (NHM, WSM) that were having
> their ldlat= value encoded as python's None.
>
> Fixes: ffc606ada3d7 ("perf jevents: Add python converter script")
> Reported-by: kernel test robot <yi1.lai@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202611050801.67bb4af4-lkp@intel.com
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105044841.102295-1-irogers@google.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf jevents: Don't encode MSRs with no value
2026-11-05 4:48 [PATCH v1] perf jevents: Don't encode MSRs with no value Ian Rogers
2026-11-05 4:53 ` sashiko-bot
@ 2026-11-05 5:42 ` Mi, Dapeng
1 sibling, 0 replies; 3+ messages in thread
From: Mi, Dapeng @ 2026-11-05 5:42 UTC (permalink / raw)
To: Ian Rogers, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Jiri Olsa, Adrian Hunter, James Clark, Edward Baker,
Thomas Falcon, Perry Taylor, linux-perf-users, linux-kernel
Cc: kernel test robot
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
On 11/5/2026 12:48 PM, Ian Rogers wrote:
> Fixes the events mem_trans_retired.load_latency (EMR) and
> mem_inst_retired.latency_above_threshold_0 (NHM, WSM) that were having
> their ldlat= value encoded as python's None.
>
> Fixes: ffc606ada3d7 ("perf jevents: Add python converter script")
> Reported-by: kernel test robot <yi1.lai@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202611050801.67bb4af4-lkp@intel.com
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/pmu-events/jevents.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
> index 080e04b51b8c..e083f7495e67 100755
> --- a/tools/perf/pmu-events/jevents.py
> +++ b/tools/perf/pmu-events/jevents.py
> @@ -396,7 +396,7 @@ class JsonEvent:
> event += f',{value}{canonicalize_value(jd[key])}'
> if filter:
> event += f',{filter}'
> - if msr:
> + if msr and msrval:
> event += f',{msr}{msrval}'
> if self.desc and extra_desc:
> self.desc += extra_desc
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-05 5:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-05 4:48 [PATCH v1] perf jevents: Don't encode MSRs with no value Ian Rogers
2026-11-05 4:53 ` sashiko-bot
2026-11-05 5:42 ` Mi, Dapeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox