Re: [PATCH v7 1/4] perf symbols: Split out name-independent duplicate symbol selection

[sashiko-bot@kernel.org]

> From: Alireza Haghdoost <haghdoost@uber.com>
> 
> This patch is a refactoring and does not change behavior. It moves the
> size, type and binding checks from choose_best_symbol() to
> choose_best_symbol_by_attrs(), and adds symbol__choice_needs_names() to
> tell whether choosing between two symbols needs their names.
> 
> symbols__fixup_duplicate() keeps one of the symbols that share a start
> address. It compares size, type and binding first. If those are equal,
> it compares leading underscores, name lengths and the result of
> arch__choose_best_symbol().
> 
> An unresolved lazy symbol stores a file offset instead of a name
> pointer, so the lazy loader cannot call choose_best_symbol() before it
> has read both names. The new helper lets it leave the names unread when
> the attributes already pick one of the symbols.
> 
> Reviewed-by: Ian Rogers <irogers@google.com>
> Signed-off-by: Alireza Haghdoost <haghdoost@uber.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-perf-symbol-memory-send-v7-0-d992eced9f9c@uber.com?part=1