From: sashiko-bot@kernel.org
To: "Alireza Haghdoost" <haghdoost@uber.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v7 2/4] perf symbols: Point to the symbol name instead of embedding it
Date: Sat, 14 Nov 2026 05:16:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-214164@kernel.org> (raw)
In-Reply-To: <20261113-perf-symbol-memory-send-v7-2-d992eced9f9c@uber.com>
> From: Alireza Haghdoost <haghdoost@uber.com>
>
> This patch changes the name field of struct symbol from a flexible
> array (char name[]) to a pointer (char *name). It does not change
> behavior, but each symbol allocation grows by 8 bytes on 64-bit hosts.
>
> The next patch creates symbols whose names are read only when needed.
> perf does not know the length of such a name when it creates the symbol,
> so it cannot allocate the name after the symbol. It cannot reallocate
> the symbol later either, because the rb-tree and the callers hold
> pointers to it. With a pointer, the name is allocated separately and set
> when it is read.
>
> Reviewed-by: Ian Rogers <irogers@google.com>
> Signed-off-by: Alireza Haghdoost <haghdoost@uber.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-perf-symbol-memory-send-v7-0-d992eced9f9c@uber.com?part=2
next prev parent reply other threads:[~2026-11-14 5:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 5:09 [PATCH v7 0/4] perf script: Lazy symbol loading Alireza Haghdoost via B4 Relay
2026-11-14 5:09 ` [PATCH v7 1/4] perf symbols: Split out name-independent duplicate symbol selection Alireza Haghdoost via B4 Relay
2026-11-14 5:12 ` sashiko-bot
2026-11-14 5:09 ` [PATCH v7 2/4] perf symbols: Point to the symbol name instead of embedding it Alireza Haghdoost via B4 Relay
2026-11-14 5:16 ` sashiko-bot [this message]
2026-11-14 5:09 ` [PATCH v7 3/4] perf script: Add --lazy-load-symbols to load symbol names lazily Alireza Haghdoost via B4 Relay
2026-11-14 5:31 ` sashiko-bot
2026-11-14 5:09 ` [PATCH v7 4/4] perf test: Test lazy symbol name loading Alireza Haghdoost via B4 Relay
2026-11-14 5:19 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-214164@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=haghdoost@uber.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox