Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 7/9] perf symbol: Add memory shrinking for symbols, DSOs, and machines
Date: Mon, 16 Nov 2026 07:36:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-216442@kernel.org> (raw)
In-Reply-To: <20261116063435.2817923-8-irogers@google.com>

> When profiling large workloads or systems with thousands of processes and
> shared libraries, perf can accumulate significant memory in loaded DSO
> symbol tables, secondary name-sorted symbol indices, cached DSO file data,
> and DWARF/addr2line state.
> 
> Because the lifetime of struct symbol is controlled by its owning
> struct dso, symbols in a referenced DSO (refcnt > 1) must remain valid for
> the lifetime of the DSO reference. However, auxiliary per-DSO allocations
> and unreferenced DSOs can still be reclaimed under memory pressure:
> 
> 1. symbols__shrink(): Reclaims the secondary name-sorted index
>    (symbols_by_name, which is rebuilt on demand by dso__sort_by_name())
>    and trims unused over-allocated tail capacity in the symbols array.
> 
> 2. dso__shrink(): Releases cached DSO resources (open file descriptor,
>    cached 4KB data pages, addr2line handles, and libdw DWARF contexts).
>    When a DSO in a dsos collection has no external references
>    (refcnt == 1), dso__shrink() also evicts its unannotated symbol table
>    via symbols__try_delete_unannotated() and marks the DSO unloaded so it
>    can be reloaded on demand if mapped again; otherwise it calls
>    symbols__shrink() to reclaim auxiliary symbol arrays.
> 
> 3. dsos__shrink(), machine__shrink(), machines__shrink(), and
>    perf_session__shrink(): Walk the session's host and guest machines to
>    shrink DSOs and evict unreferenced user DSOs (refcnt == 1, not kernel,
>    not vDSO, not hit, and not carrying header build-ids), followed by
>    malloc_trim(0) on glibc to return freed heap pages to the OS.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116063435.2817923-1-irogers@google.com?part=7


  reply	other threads:[~2026-11-16  7:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  6:34 [PATCH v5 0/9] perf symbol: Sorted arrays, DSO-owned lifetimes, and memory shrinking Ian Rogers
2026-11-16  6:34 ` [PATCH v5 1/9] perf call-path: Use struct dso_symbol to retain symbol DSO lifetimes Ian Rogers
2026-11-16  6:44   ` sashiko-bot
2026-11-16  6:34 ` [PATCH v5 2/9] perf annotate: Move struct annotation to a hashmap and remove symbol_conf.priv_size Ian Rogers
2026-11-16  6:51   ` sashiko-bot
2026-11-16  6:34 ` [PATCH v5 3/9] perf symbol-elf: Cache ELF program/section headers and defer symbol name lookup Ian Rogers
2026-11-16  6:48   ` sashiko-bot
2026-11-16  6:34 ` [PATCH v5 4/9] perf maps: Optimize tail insertion and small-append sorting Ian Rogers
2026-11-16  7:06   ` sashiko-bot
2026-11-16  6:34 ` [PATCH v5 5/9] perf symbol: Switch backing storage from rbtree to struct symbols array Ian Rogers
2026-11-16  7:20   ` sashiko-bot
2026-11-16  6:34 ` [PATCH v5 6/9] perf symbol: Optimize symbol sorting with natural-run merge sort and binary insertion Ian Rogers
2026-11-16  7:18   ` sashiko-bot
2026-11-16  6:34 ` [PATCH v5 7/9] perf symbol: Add memory shrinking for symbols, DSOs, and machines Ian Rogers
2026-11-16  7:36   ` sashiko-bot [this message]
2026-11-16  6:34 ` [PATCH v5 8/9] perf session: Add dso__session() and session-scoped allocation wrappers Ian Rogers
2026-11-16  7:40   ` sashiko-bot
2026-11-16  6:34 ` [PATCH v5 9/9] perf test symbols: Add tests for symbol shrinking and session alloc wrappers Ian Rogers
2026-11-16  7:45   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216442@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox