From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v5 9/9] perf test symbols: Add tests for symbol shrinking and session alloc wrappers
Date: Mon, 16 Nov 2026 07:45:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-216456@kernel.org> (raw)
In-Reply-To: <20261116063435.2817923-10-irogers@google.com>
> Ensure the new symbol sorting, DSO-lifetime symbol and DSO shrinking,
> dso_symbol reference pinning, on-demand DSO reload after unreferenced
> eviction, and session-scoped allocation wrappers are verified by
> 'perf test symbols' (including under REFCNT_CHECKING=1).
>
> Add unit tests to 'perf test symbols' covering:
> - test_symbols_sorted_insert(): Verify ascending symbols__insert(),
> out-of-order dso__insert_symbol() maintaining sorted order, and
> unsorted symbols__insert() followed by sort-on-lookup in
> dso__find_symbol().
> - test_symbols_shrink(): Verify symbols__shrink() reclaims the secondary
> symbols_by_name index and trims unused capacity in symbols->symbols
> while keeping live symbols intact, and verify
> symbols__try_delete_unannotated() preserves annotated symbol tables.
> - test_dsos_shrink(): Verify dsos__shrink() evicts unreferenced user
> DSOs while retaining DSOs with active external references and vDSOs.
> - test_session_alloc_shrink(): Verify machine__session(),
> dso__session(), perf_session__malloc/zalloc/calloc/realloc/strdup(),
> and perf_session__shrink().
> - test_dso_shrink_and_reload(): Verify dso__shrink() on a referenced ELF
> DSO reclaims auxiliary buffers while preserving symbol pointers,
> dso_symbol__copy() pins DSO symbols across dsos__shrink() until
> dso_symbol__exit(), and dsos__shrink() on an unreferenced hit DSO
> evicts its symbol table and transparently reloads it on a subsequent
> map__find_symbol().
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116063435.2817923-1-irogers@google.com?part=9
prev parent reply other threads:[~2026-11-16 7:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 6:34 [PATCH v5 0/9] perf symbol: Sorted arrays, DSO-owned lifetimes, and memory shrinking Ian Rogers
2026-11-16 6:34 ` [PATCH v5 1/9] perf call-path: Use struct dso_symbol to retain symbol DSO lifetimes Ian Rogers
2026-11-16 6:44 ` sashiko-bot
2026-11-16 6:34 ` [PATCH v5 2/9] perf annotate: Move struct annotation to a hashmap and remove symbol_conf.priv_size Ian Rogers
2026-11-16 6:51 ` sashiko-bot
2026-11-16 6:34 ` [PATCH v5 3/9] perf symbol-elf: Cache ELF program/section headers and defer symbol name lookup Ian Rogers
2026-11-16 6:48 ` sashiko-bot
2026-11-16 6:34 ` [PATCH v5 4/9] perf maps: Optimize tail insertion and small-append sorting Ian Rogers
2026-11-16 7:06 ` sashiko-bot
2026-11-16 6:34 ` [PATCH v5 5/9] perf symbol: Switch backing storage from rbtree to struct symbols array Ian Rogers
2026-11-16 7:20 ` sashiko-bot
2026-11-16 6:34 ` [PATCH v5 6/9] perf symbol: Optimize symbol sorting with natural-run merge sort and binary insertion Ian Rogers
2026-11-16 7:18 ` sashiko-bot
2026-11-16 6:34 ` [PATCH v5 7/9] perf symbol: Add memory shrinking for symbols, DSOs, and machines Ian Rogers
2026-11-16 7:36 ` sashiko-bot
2026-11-16 6:34 ` [PATCH v5 8/9] perf session: Add dso__session() and session-scoped allocation wrappers Ian Rogers
2026-11-16 7:40 ` sashiko-bot
2026-11-16 6:34 ` [PATCH v5 9/9] perf test symbols: Add tests for symbol shrinking and session alloc wrappers Ian Rogers
2026-11-16 7:45 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216456@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox