Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v6 13/13] perf test: Skip the LBR inline unwinding check when unsupported
Date: Tue, 17 Nov 2026 20:29:25 +0000	[thread overview]
Message-ID: <sashiko-outbox-219605@kernel.org> (raw)
In-Reply-To: <20261117200433.45174-14-acme@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] perf test: test_lbr() fails to skip on AMD BRS due to EINVAL
  vs EOPNOTSUPP
--

commit d21ae617447c59168b264906c4d199925c28a698
Author: Arnaldo Carvalho de Melo <acme@redhat.com>

perf test: Skip the LBR inline unwinding check when unsupported

This commit updates test_lbr() in addr2line_inlines.sh to skip the LBR
test when perf record reports that the PMU does not support branch stack
sampling.

> diff --git a/tools/perf/tests/shell/addr2line_inlines.sh b/tools/perf/tests/shell/addr2line_inlines.sh
> index e8754ef2d7f21..ca88a6b886ca1 100755
> --- a/tools/perf/tests/shell/addr2line_inlines.sh
> +++ b/tools/perf/tests/shell/addr2line_inlines.sh
[ ... ]
> @@ -71,7 +73,22 @@ test_lbr() {
>      fi
>  
>      # Record data. Currently only dwarf callchains support inlined functions.
> -    perf record --call-graph lbr -e cycles:u -o "${perf_data}" -- perf test -w inlineloop 1
> +    # Some PMUs advertise branches but reject branch sampling for cycles, e.g.
> +    # AMD BRS, which only samples its own retired branches event.
> +    if ! perf record --call-graph lbr -e cycles:u -o "${perf_data}" -- \
> +            perf test -w inlineloop 1 2> "${perf_record_err}"
> +    then
> +        if grep -Fq "doesn't support branch stack sampling" "${perf_record_err}"
> +        then
> +            echo "Skip: LBR not supported by the PMU"
> +            lbr_skipped=1
> +        else
> +            cat "${perf_record_err}"
> +            echo "Inline unwinding lbr verification test [Failed to record]"
> +            err=1
> +        fi
> +        return
> +    fi

[Severity: Medium]
Does test_lbr() still fail on AMD BRS instead of skipping?

On AMD BRS, amd_brs_hw_config() rejects non-BRS events such as cycles:u
with -EINVAL rather than -EOPNOTSUPP:

arch/x86/events/amd/brs.c:amd_brs_hw_config() {
    ...
	if (!amd_is_brs_event(event))
		return -EINVAL;
    ...
}

In tools/perf/util/evsel.c, evsel__open_strerror() only formats the
"doesn't support branch stack sampling" message under case EOPNOTSUPP, and
falls through to the generic Invalid argument message for EINVAL.  As a
result, grep does not match perf_record_err on AMD BRS and test_lbr() still
enters the else branch and fails with err=1.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117200433.45174-1-acme@kernel.org?part=13

      reply	other threads:[~2026-11-17 20:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 20:04 [PATCH v6 0/13] perf coverage: A harness for perf, and the fixes it found Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 01/13] perf jvmti: Link the agent with EXTRA_CFLAGS Arnaldo Carvalho de Melo
2026-11-17 20:10   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 02/13] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-17 20:15   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 03/13] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-17 20:35   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 04/13] perf tests: Exercise DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-17 20:13   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 05/13] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-17 20:11   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 06/13] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-17 20:10   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 07/13] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-17 20:20   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 08/13] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-17 20:11   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 09/13] perf tests: Silence the libbfd probe in build-test Arnaldo Carvalho de Melo
2026-11-17 20:08   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 10/13] perf build: Record the display-only features in FEATURE-DUMP Arnaldo Carvalho de Melo
2026-11-17 20:15   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 11/13] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-17 20:18   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 12/13] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-17 20:12   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 13/13] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo
2026-11-17 20:29   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219605@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=acme@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox