From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Pritam Manohar Sutar <pritam.sutar@samsung.com>,
vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com,
andre.draszik@linaro.org, peter.griffin@linaro.org,
kauschluss@disroot.org, m.szyprowski@samsung.com,
s.nawrocki@samsung.com
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rosa.pila@samsung.com,
dev.tailor@samsung.com, faraz.ata@samsung.com,
muhammed.ali@samsung.com, selvarasu.g@samsung.com
Subject: Re: [PATCH v2 2/2] phy: exyons5-usbdrd: support HS phy for ExynosAutov920
Date: Thu, 22 May 2025 09:22:06 +0200 [thread overview]
Message-ID: <09533aad-fbec-477d-a088-5ecbe181368b@linaro.org> (raw)
In-Reply-To: <bd9ab640-2469-4455-bd69-302dd3898c7b@kernel.org>
On 21/05/2025 14:58, Krzysztof Kozlowski wrote:
> On 21/05/2025 14:56, 'Neil Armstrong' wrote:
>>>> <snip>
>>>>
>>>>> + }, {
>>>>> + .compatible = "samsung,exynosautov920-usb31drd-phy",
>>>>> + .data = &exynosautov920_usb31drd_phy
>>>>
>>>> All those new ops are only called when matching this compatible, it it really
>>>> necessary to check the version ? is there "samsung,exynosautov920-usb31drd-
>>>> phy" PHYs with version different from 3 in the wild ?
>>>>
>>>
>>> This SoC has a single USB 3.1 DRD combo phy of version v400 (major : minor versions) and three USB2.0
>>> DRD phy v303 (major : minor versions) controllers those only support the UTMI+ interface. Currently,
>>> supporting only v303 phys in this patch-set, and planning v400 phy later (soon).
>>>
>>> Yes, there's v400 phy version that is different from v303 phy. Hence, phy version check is needed to support both the phys for same compatible.
>>
>> OK so add 2 compatibles, one for the usb31drd and one for the usb2drd since those are 2 difference hardware.
>
> ...unless this is fully detectable hardware, then use fallbacks and only
> one compatible in the driver.
But use proper compatible like "samsung,exynosautov92-usb-phy", but still those are
2 very different PHYs connected to different HW blocks, I won't mix USB3.1 and USB2 PHY
compatibles.
Neil
>
> Best regards,
> Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2025-05-22 7:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250516101757epcas5p368f98b909ff50c91700358f65228e066@epcas5p3.samsung.com>
2025-05-16 10:26 ` [PATCH v2 0/2] initial usbdrd phy support for Exynosautov920 soc Pritam Manohar Sutar
2025-05-16 10:26 ` [PATCH v2 1/2] dt-bindings: phy: samsung,usb3-drd-phy: add dt-schema for ExynosAutov920 Pritam Manohar Sutar
2025-05-20 7:45 ` Krzysztof Kozlowski
2025-05-21 6:48 ` Pritam Manohar Sutar
2025-05-21 8:44 ` Krzysztof Kozlowski
2025-05-21 11:08 ` Pritam Manohar Sutar
2025-05-16 10:26 ` [PATCH v2 2/2] phy: exyons5-usbdrd: support HS phy " Pritam Manohar Sutar
2025-05-20 7:39 ` neil.armstrong
2025-05-20 7:42 ` Krzysztof Kozlowski
2025-05-21 7:10 ` Pritam Manohar Sutar
2025-05-21 8:47 ` Krzysztof Kozlowski
2025-05-21 8:58 ` Krzysztof Kozlowski
2025-05-21 6:56 ` Pritam Manohar Sutar
2025-05-21 12:56 ` 'Neil Armstrong'
2025-05-21 12:58 ` Krzysztof Kozlowski
2025-05-22 7:22 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09533aad-fbec-477d-a088-5ecbe181368b@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dev.tailor@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=faraz.ata@samsung.com \
--cc=kauschluss@disroot.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=muhammed.ali@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=pritam.sutar@samsung.com \
--cc=robh@kernel.org \
--cc=rosa.pila@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=selvarasu.g@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox