From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pritam Manohar Sutar <pritam.sutar@samsung.com>,
vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com,
andre.draszik@linaro.org, peter.griffin@linaro.org,
kauschluss@disroot.org, m.szyprowski@samsung.com,
s.nawrocki@samsung.com
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rosa.pila@samsung.com,
dev.tailor@samsung.com, faraz.ata@samsung.com,
muhammed.ali@samsung.com, selvarasu.g@samsung.com
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: samsung,usb3-drd-phy: add dt-schema for ExynosAutov920
Date: Wed, 21 May 2025 10:44:50 +0200 [thread overview]
Message-ID: <a584146d-df86-4e40-8a0f-c3b7558fd066@kernel.org> (raw)
In-Reply-To: <000001dbca1c$636ca080$2a45e180$@samsung.com>
On 21/05/2025 08:48, Pritam Manohar Sutar wrote:
>>> diff --git
>>> a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
>>> b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
>>> index fdddddc7d611..c50f4218ded9 100644
>>> --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
>>> +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
>>> @@ -32,6 +32,7 @@ properties:
>>> - samsung,exynos7-usbdrd-phy
>>> - samsung,exynos7870-usbdrd-phy
>>> - samsung,exynos850-usbdrd-phy
>>> + - samsung,exynosautov920-usb31drd-phy
>>>
>>> clocks:
>>> minItems: 2
>>> @@ -204,6 +205,32 @@ allOf:
>>> reg-names:
>>> maxItems: 1
>>>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: samsung,exynosautov920-usb31drd-phy
>>> + then:
>>> + $ref: /schemas/usb/usb-switch.yaml#
>>> +
>>> + properties:
>>> + clocks:
>>> + items:
>>
>> Why there is no main PHY clock?
>
> external crystal clk (ext_xtal) is used as main phy clk.
So this is the main phy clock? This describes the clock input, not what
you have on your board. If you change external crystal to internal clock
in one design, you change the binding? No, this makes no sense.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-05-21 8:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250516101757epcas5p368f98b909ff50c91700358f65228e066@epcas5p3.samsung.com>
2025-05-16 10:26 ` [PATCH v2 0/2] initial usbdrd phy support for Exynosautov920 soc Pritam Manohar Sutar
2025-05-16 10:26 ` [PATCH v2 1/2] dt-bindings: phy: samsung,usb3-drd-phy: add dt-schema for ExynosAutov920 Pritam Manohar Sutar
2025-05-20 7:45 ` Krzysztof Kozlowski
2025-05-21 6:48 ` Pritam Manohar Sutar
2025-05-21 8:44 ` Krzysztof Kozlowski [this message]
2025-05-21 11:08 ` Pritam Manohar Sutar
2025-05-16 10:26 ` [PATCH v2 2/2] phy: exyons5-usbdrd: support HS phy " Pritam Manohar Sutar
2025-05-20 7:39 ` neil.armstrong
2025-05-20 7:42 ` Krzysztof Kozlowski
2025-05-21 7:10 ` Pritam Manohar Sutar
2025-05-21 8:47 ` Krzysztof Kozlowski
2025-05-21 8:58 ` Krzysztof Kozlowski
2025-05-21 6:56 ` Pritam Manohar Sutar
2025-05-21 12:56 ` 'Neil Armstrong'
2025-05-21 12:58 ` Krzysztof Kozlowski
2025-05-22 7:22 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a584146d-df86-4e40-8a0f-c3b7558fd066@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dev.tailor@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=faraz.ata@samsung.com \
--cc=kauschluss@disroot.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=muhammed.ali@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=pritam.sutar@samsung.com \
--cc=robh@kernel.org \
--cc=rosa.pila@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=selvarasu.g@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox