* [PATCH] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()
@ 2026-03-25 16:23 Felix Gu
2026-03-26 8:56 ` Ze Huang
2026-05-10 12:24 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Felix Gu @ 2026-03-25 16:23 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Yixun Lan, Ze Huang
Cc: linux-phy, linux-riscv, spacemit, linux-kernel, Felix Gu
When clk_enable() fails, the clock was never enabled. Calling
clk_disable() in this error path is incorrect.
Remove the spurious clk_disable() call from the error handling
in spacemit_usb2phy_init().
Fixes: fe4bc1a08638 ("phy: spacemit: support K1 USB2.0 PHY controller")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/phy/spacemit/phy-k1-usb2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/phy/spacemit/phy-k1-usb2.c b/drivers/phy/spacemit/phy-k1-usb2.c
index 9215d0b223b2..e8c1e26428a9 100644
--- a/drivers/phy/spacemit/phy-k1-usb2.c
+++ b/drivers/phy/spacemit/phy-k1-usb2.c
@@ -97,7 +97,6 @@ static int spacemit_usb2phy_init(struct phy *phy)
ret = clk_enable(sphy->clk);
if (ret) {
dev_err(&phy->dev, "failed to enable clock\n");
- clk_disable(sphy->clk);
return ret;
}
---
base-commit: 85964cdcad0fac9a0eb7b87a0f9d88cc074b854c
change-id: 20260326-k1-usb3-f6a52f413616
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()
2026-03-25 16:23 [PATCH] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init() Felix Gu
@ 2026-03-26 8:56 ` Ze Huang
2026-05-10 12:24 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Ze Huang @ 2026-03-26 8:56 UTC (permalink / raw)
To: Felix Gu, Vinod Koul, Neil Armstrong, Yixun Lan, Ze Huang
Cc: linux-phy, linux-riscv, spacemit, linux-kernel
On Thu Mar 26, 2026 at 12:23 AM CST, Felix Gu wrote:
> When clk_enable() fails, the clock was never enabled. Calling
> clk_disable() in this error path is incorrect.
>
> Remove the spurious clk_disable() call from the error handling
> in spacemit_usb2phy_init().
>
> Fixes: fe4bc1a08638 ("phy: spacemit: support K1 USB2.0 PHY controller")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
> drivers/phy/spacemit/phy-k1-usb2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/spacemit/phy-k1-usb2.c b/drivers/phy/spacemit/phy-k1-usb2.c
> index 9215d0b223b2..e8c1e26428a9 100644
> --- a/drivers/phy/spacemit/phy-k1-usb2.c
> +++ b/drivers/phy/spacemit/phy-k1-usb2.c
> @@ -97,7 +97,6 @@ static int spacemit_usb2phy_init(struct phy *phy)
> ret = clk_enable(sphy->clk);
> if (ret) {
> dev_err(&phy->dev, "failed to enable clock\n");
> - clk_disable(sphy->clk);
> return ret;
> }
>
>
> ---
> base-commit: 85964cdcad0fac9a0eb7b87a0f9d88cc074b854c
> change-id: 20260326-k1-usb3-f6a52f413616
>
> Best regards,
Indeed, thanks for catching this.
Reviewed-by: Ze Huang <huang.ze@linux.dev>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()
2026-03-25 16:23 [PATCH] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init() Felix Gu
2026-03-26 8:56 ` Ze Huang
@ 2026-05-10 12:24 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2026-05-10 12:24 UTC (permalink / raw)
To: Neil Armstrong, Yixun Lan, Ze Huang, Felix Gu
Cc: linux-phy, linux-riscv, spacemit, linux-kernel
On Thu, 26 Mar 2026 00:23:58 +0800, Felix Gu wrote:
> When clk_enable() fails, the clock was never enabled. Calling
> clk_disable() in this error path is incorrect.
>
> Remove the spurious clk_disable() call from the error handling
> in spacemit_usb2phy_init().
>
>
> [...]
Applied, thanks!
[1/1] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init()
commit: a4058c09dd6e28ec33316fd6eb45ddae4cab1f31
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-10 12:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-25 16:23 [PATCH] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init() Felix Gu
2026-03-26 8:56 ` Ze Huang
2026-05-10 12:24 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox