* Re: [PATCH v2 1/1] phy: qualcomm: m31-eusb2: Add register XCFGI_159_152 for SE0 recovery
2026-10-27 1:55 [PATCH v2 1/1] phy: qualcomm: m31-eusb2: Add register XCFGI_159_152 for SE0 recovery Peter Chen
@ 2026-10-27 11:15 ` Abel Vesa
2026-10-27 12:21 ` Krishna Kurapati
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-10-27 11:15 UTC (permalink / raw)
To: Peter Chen
Cc: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Konrad Dybcio,
Elson Serrao, Ronak Raheja, Wesley Cheng, Udipto Goswami,
Jack Pham, Pratham Pratap, Krishna Kurapati, linux-arm-msm,
linux-phy, linux-kernel
On 26-10-26 18:55:45, Peter Chen wrote:
> From: Elson Serrao <elson.serrao@oss.qualcomm.com>
>
> This patch introduces support for the XCFGI_159_152 register to enable a
> hardware-based SE0 recovery mechanism in the M31 PHY when operating in
> host mode.
>
> During PHY initialization, spurious pulses from external devices can
> interfere with speed negotiation, potentially leading to abnormal
> behavior. To mitigate this, the M31 PHY provides a fail-safe mechanism
> controlled by bit 159 of the XCFGI register.
>
> When XCFG_SE0_TIMEOUT_EN (bit 159) is set, a hardware counter is
> activated to monitor the SE0 state. If SE0 persists for more than 2.5 ms
> before entering L0 mode, the PHY interprets this as bus inactivity and
> resets the state machine to its default state. After transitioning to
> L0, the PHY resumes normal operation in accordance with the eUSB
> specification.
>
> Fixes: 9c8504861cc4 ("phy: qcom: Add M31 based eUSB2 PHY driver")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Elson Serrao <elson.serrao@oss.qualcomm.com>
> Signed-off-by: Peter Chen <peter.chen@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/1] phy: qualcomm: m31-eusb2: Add register XCFGI_159_152 for SE0 recovery
2026-10-27 1:55 [PATCH v2 1/1] phy: qualcomm: m31-eusb2: Add register XCFGI_159_152 for SE0 recovery Peter Chen
2026-10-27 11:15 ` Abel Vesa
@ 2026-10-27 12:21 ` Krishna Kurapati
2026-10-31 16:24 ` Christian Cortner
2026-11-15 19:28 ` Manivannan Sadhasivam
3 siblings, 0 replies; 5+ messages in thread
From: Krishna Kurapati @ 2026-10-27 12:21 UTC (permalink / raw)
To: Peter Chen
Cc: Neil Armstrong, Manivannan Sadhasivam, Konrad Dybcio,
Elson Serrao, Ronak Raheja, Vinod Koul, Wesley Cheng,
Udipto Goswami, Jack Pham, Pratham Pratap, linux-arm-msm,
linux-phy, linux-kernel
On 10/27/2026 7:25 AM, Peter Chen wrote:
> From: Elson Serrao <elson.serrao@oss.qualcomm.com>
>
> This patch introduces support for the XCFGI_159_152 register to enable a
> hardware-based SE0 recovery mechanism in the M31 PHY when operating in
> host mode.
>
> During PHY initialization, spurious pulses from external devices can
> interfere with speed negotiation, potentially leading to abnormal
> behavior. To mitigate this, the M31 PHY provides a fail-safe mechanism
> controlled by bit 159 of the XCFGI register.
>
> When XCFG_SE0_TIMEOUT_EN (bit 159) is set, a hardware counter is
> activated to monitor the SE0 state. If SE0 persists for more than 2.5 ms
> before entering L0 mode, the PHY interprets this as bus inactivity and
> resets the state machine to its default state. After transitioning to
> L0, the PHY resumes normal operation in accordance with the eUSB
> specification.
>
> Fixes: 9c8504861cc4 ("phy: qcom: Add M31 based eUSB2 PHY driver")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Elson Serrao <elson.serrao@oss.qualcomm.com>
> Signed-off-by: Peter Chen <peter.chen@oss.qualcomm.com>
Reviewed-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> Changes for v2:
> - Add Fixes and Reviewed-by tags
> - Link to v1: https://lore.kernel.org/all/20261020061811.3127511-1-peter.chen@oss.qualcomm.com/
>
> drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> index 275df38256de..8d954e772585 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> @@ -56,6 +56,9 @@
> #define USB_PHY_XCFGI_7_0 (0x15c)
> #define PLL_LOCK_TIME GENMASK(1, 0)
>
> +#define USB_PHY_XCFGI_159_152 (0x1a8)
> +#define SE0_TIMEOUT_EN BIT(7)
> +
> #define M31_EUSB_PHY_INIT_CFG(o, b, v) \
> { \
> .off = o, \
> @@ -88,6 +91,13 @@ static const struct m31_phy_tbl_entry m31_eusb2_setup_tbl[] = {
> };
>
> static const struct m31_phy_tbl_entry m31_eusb_phy_override_tbl[] = {
> + /*
> + * Set XCFGI[159] to enable SE0 timeout mechanism in M31.
> + * This enables a counter which will assume bus inactive if
> + * SE0 is more than 2.5ms and reset the state machine to default
> + * state.
> + */
> + M31_EUSB_PHY_INIT_CFG(USB_PHY_XCFGI_159_152, SE0_TIMEOUT_EN, 1),
> M31_EUSB_PHY_INIT_CFG(USB_PHY_XCFGI_39_32, HSTX_PE, 0),
> M31_EUSB_PHY_INIT_CFG(USB_PHY_XCFGI_71_64, HSTX_SWING, 7),
> M31_EUSB_PHY_INIT_CFG(USB_PHY_XCFGI_31_24, HSTX_SLEW, 0),
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/1] phy: qualcomm: m31-eusb2: Add register XCFGI_159_152 for SE0 recovery
2026-10-27 1:55 [PATCH v2 1/1] phy: qualcomm: m31-eusb2: Add register XCFGI_159_152 for SE0 recovery Peter Chen
2026-10-27 11:15 ` Abel Vesa
2026-10-27 12:21 ` Krishna Kurapati
@ 2026-10-31 16:24 ` Christian Cortner
2026-11-15 19:28 ` Manivannan Sadhasivam
3 siblings, 0 replies; 5+ messages in thread
From: Christian Cortner @ 2026-10-31 16:24 UTC (permalink / raw)
To: Peter Chen, Vinod Koul
Cc: Neil Armstrong, Manivannan Sadhasivam, Konrad Dybcio,
Elson Serrao, Ronak Raheja, Wesley Cheng, Udipto Goswami,
Jack Pham, Pratham Pratap, Krishna Kurapati, linux-arm-msm,
linux-phy, linux-kernel
Tested-by: Christian Cortner <ccortner@gmail.com> # Asus Zenbook A16 (UX3607OA)
Before it, a USB SSD on a800000.usb dropped twice in a day with
error -71 and "not accepting address". With it: 28 GB written in a
stress test, and no such errors in 27 boots since.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] phy: qualcomm: m31-eusb2: Add register XCFGI_159_152 for SE0 recovery
2026-10-27 1:55 [PATCH v2 1/1] phy: qualcomm: m31-eusb2: Add register XCFGI_159_152 for SE0 recovery Peter Chen
` (2 preceding siblings ...)
2026-10-31 16:24 ` Christian Cortner
@ 2026-11-15 19:28 ` Manivannan Sadhasivam
3 siblings, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2026-11-15 19:28 UTC (permalink / raw)
To: Peter Chen
Cc: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Konrad Dybcio,
Elson Serrao, Ronak Raheja, Wesley Cheng, Udipto Goswami,
Jack Pham, Pratham Pratap, Krishna Kurapati, linux-arm-msm,
linux-phy, linux-kernel
On 2026-10-26 18:55 -0700, Peter Chen wrote:
> From: Elson Serrao <elson.serrao@oss.qualcomm.com>
>
> This patch introduces support for the XCFGI_159_152 register to enable a
Avoid using 'This patch'. Once a patch gets merged, it will become a commit.
> hardware-based SE0 recovery mechanism in the M31 PHY when operating in
> host mode.
>
> During PHY initialization, spurious pulses from external devices can
> interfere with speed negotiation, potentially leading to abnormal
> behavior. To mitigate this, the M31 PHY provides a fail-safe mechanism
> controlled by bit 159 of the XCFGI register.
>
> When XCFG_SE0_TIMEOUT_EN (bit 159) is set, a hardware counter is
> activated to monitor the SE0 state. If SE0 persists for more than 2.5 ms
> before entering L0 mode, the PHY interprets this as bus inactivity and
> resets the state machine to its default state. After transitioning to
> L0, the PHY resumes normal operation in accordance with the eUSB
> specification.
>
Please rewrite the commit message in imperative tone.
> Fixes: 9c8504861cc4 ("phy: qcom: Add M31 based eUSB2 PHY driver")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Elson Serrao <elson.serrao@oss.qualcomm.com>
> Signed-off-by: Peter Chen <peter.chen@oss.qualcomm.com>
> ---
> Changes for v2:
> - Add Fixes and Reviewed-by tags
> - Link to v1: https://lore.kernel.org/all/20261020061811.3127511-1-peter.chen@oss.qualcomm.com/
>
> drivers/phy/qualcomm/phy-qcom-m31-eusb2.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> index 275df38256de..8d954e772585 100644
> --- a/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-m31-eusb2.c
> @@ -56,6 +56,9 @@
> #define USB_PHY_XCFGI_7_0 (0x15c)
> #define PLL_LOCK_TIME GENMASK(1, 0)
>
> +#define USB_PHY_XCFGI_159_152 (0x1a8)
> +#define SE0_TIMEOUT_EN BIT(7)
> +
> #define M31_EUSB_PHY_INIT_CFG(o, b, v) \
> { \
> .off = o, \
> @@ -88,6 +91,13 @@ static const struct m31_phy_tbl_entry m31_eusb2_setup_tbl[] = {
> };
>
> static const struct m31_phy_tbl_entry m31_eusb_phy_override_tbl[] = {
> + /*
> + * Set XCFGI[159] to enable SE0 timeout mechanism in M31.
> + * This enables a counter which will assume bus inactive if
> + * SE0 is more than 2.5ms and reset the state machine to default
> + * state.
> + */
Any reason on not making use of 80columns for comments?
With these fixed,
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
- Mani
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread