Re: ARMADA espressobin SATA drive detection failure

From: "Marek Behún" <kabel@kernel.org>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "Pali Rohár" <pali@kernel.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"Damien Le Moal" <Damien.LeMoal@wdc.com>
Subject: Re: ARMADA espressobin SATA drive detection failure
Date: Fri, 26 Aug 2022 14:05:36 +0200	[thread overview]
Message-ID: <20220826140536.68eee458@dellmb> (raw)
In-Reply-To: <20220826050019.kvb7vca6fiwzajcx@shindev>

[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]

On Fri, 26 Aug 2022 05:00:20 +0000
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com> wrote:

> On Aug 26, 2022 / 00:15, Marek Behún wrote:
> > On Thu, 25 Aug 2022 15:00:59 +0200
> > Pali Rohár <pali@kernel.org> wrote:
> >   
> > > On Sunday 14 August 2022 01:10:50 Pali Rohár wrote:  
> > > > On Saturday 13 August 2022 23:02:34 Shinichiro Kawasaki wrote:  
> 
> [...]
> 
> > > > Perfect! So the issue is with mvebu_a3700_comphy_reset() function.
> > > > 
> > > > This function is not in TF-A code and neither in my original kernel
> > > > driver implementation (still available here):
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/commit/?h=phy-mvebu-a3700-comphy&id=4588902a3528195bcfdda9f9e1e14262a1955df1
> > > > 
> > > > Marek, this function mvebu_a3700_comphy_reset() was implemented by you.
> > > > Could you please look at it, why you added this function and try to fix
> > > > it? Is this function needed at all?    
> > > 
> > > PING? Any progress here?  
> > 
> > Not yet, sorry. Maybe we could do something like I am attaching, until
> > I have time to play with it?
> > 
> > See attached file.  
> 
> Merek, thanks for the response. I applied the attached patch to v5.18.16 kernel
> and observed the "ata1: SATA link down (SStatus 100 SControl 300)" message is
> avoided. It looks working.
> 

Hello Shinichiro,

would you be able to test another patch I am attaching, on clean kernel?
Whether your disk works or not...

Thanks.

Marek

[-- Attachment #2: a3720-comphy-test-2.patch --]
[-- Type: text/x-patch, Size: 824 bytes --]

diff --git a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c b/drivers/phy/marvell/phy-mvebu-a3700-comphy.c
index a4d7d9bd100d..3bba2a02c71a 100644
--- a/drivers/phy/marvell/phy-mvebu-a3700-comphy.c
+++ b/drivers/phy/marvell/phy-mvebu-a3700-comphy.c
@@ -1104,6 +1104,14 @@ static int mvebu_a3700_comphy_reset(struct phy *phy)
 
 	dev_dbg(lane->dev, "resetting lane %d\n", lane->id);
 
+	if (lane->id == 0 || lane->id == 1)
+		comphy_periph_reg_set(lane, COMPHY_PHY_CFG1, 0,
+				      PIN_PU_PLL_BIT | PIN_PU_RX_BIT | PIN_PU_TX_BIT | PIN_PU_IVREF_BIT | PIN_TX_IDLE_BIT);
+
+	else
+		comphy_lane_reg_set(lane, COMPHY_POWER_PLL_CTRL,
+				    0x0, PU_PLL_BIT | PU_RX_BIT | PU_TX_BIT | PU_IVREF_BIT);
+
 	/* COMPHY reset for internal logic */
 	comphy_lane_reg_set(lane, COMPHY_SFT_RESET,
 			    SFT_RST_NO_REG, SFT_RST_NO_REG);

[-- Attachment #3: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
