Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] phy: starfive: make phys depend on HAS_IOMEM
@ 2023-07-25  6:38 Vinod Koul
  2023-07-25  6:44 ` Changhuang Liang
  2023-07-25 13:52 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Vinod Koul @ 2023-07-25  6:38 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Vinod Koul
  Cc: linux-phy, Minda Chen, Roger Quadros, Changhuang Liang,
	kernel test robot

the startfive phy drivers use devm_platform_ioremap_resource() which on
some archs (s390) is not present. So make the drivers depend on HAS_IOMEM

Fixes: f8aa660841bc ("phy: starfive: Add mipi dphy rx support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307250509.oeudxG28-lkp@intel.com/
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/phy/starfive/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
index a560533a674e..0508f9b123e0 100644
--- a/drivers/phy/starfive/Kconfig
+++ b/drivers/phy/starfive/Kconfig
@@ -5,6 +5,7 @@
 
 config PHY_STARFIVE_JH7110_DPHY_RX
 	tristate "StarFive JH7110 D-PHY RX support"
+	depends on HAS_IOMEM
 	select GENERIC_PHY
 	select GENERIC_PHY_MIPI_DPHY
 	help
-- 
2.41.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] phy: starfive: make phys depend on HAS_IOMEM
  2023-07-25  6:38 [PATCH v2] phy: starfive: make phys depend on HAS_IOMEM Vinod Koul
@ 2023-07-25  6:44 ` Changhuang Liang
  2023-07-25 13:52 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Changhuang Liang @ 2023-07-25  6:44 UTC (permalink / raw)
  To: Vinod Koul, Kishon Vijay Abraham I
  Cc: linux-phy, Minda Chen, Roger Quadros, kernel test robot



On 2023/7/25 14:38, Vinod Koul wrote:
> the startfive phy drivers use devm_platform_ioremap_resource() which on
> some archs (s390) is not present. So make the drivers depend on HAS_IOMEM
> 
> Fixes: f8aa660841bc ("phy: starfive: Add mipi dphy rx support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307250509.oeudxG28-lkp@intel.com/
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>

> ---
>  drivers/phy/starfive/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
> index a560533a674e..0508f9b123e0 100644
> --- a/drivers/phy/starfive/Kconfig
> +++ b/drivers/phy/starfive/Kconfig
> @@ -5,6 +5,7 @@
>  
>  config PHY_STARFIVE_JH7110_DPHY_RX
>  	tristate "StarFive JH7110 D-PHY RX support"
> +	depends on HAS_IOMEM
>  	select GENERIC_PHY
>  	select GENERIC_PHY_MIPI_DPHY
>  	help


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] phy: starfive: make phys depend on HAS_IOMEM
  2023-07-25  6:38 [PATCH v2] phy: starfive: make phys depend on HAS_IOMEM Vinod Koul
  2023-07-25  6:44 ` Changhuang Liang
@ 2023-07-25 13:52 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-07-25 13:52 UTC (permalink / raw)
  To: Kishon Vijay Abraham I, Vinod Koul
  Cc: linux-phy, Minda Chen, Roger Quadros, Changhuang Liang,
	kernel test robot


On Tue, 25 Jul 2023 12:08:56 +0530, Vinod Koul wrote:
> the startfive phy drivers use devm_platform_ioremap_resource() which on
> some archs (s390) is not present. So make the drivers depend on HAS_IOMEM
> 
> 

Applied, thanks!

[1/1] phy: starfive: make phys depend on HAS_IOMEM
      commit: ec6beb82587c73cff52730567016cbc6c17822a8

Best regards,
-- 
~Vinod



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-25 13:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25  6:38 [PATCH v2] phy: starfive: make phys depend on HAS_IOMEM Vinod Koul
2023-07-25  6:44 ` Changhuang Liang
2023-07-25 13:52 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox