* [PATCH v3 1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
2025-04-15 4:22 [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424 Kathiravan Thirumoorthy
@ 2025-04-15 4:22 ` Kathiravan Thirumoorthy
2025-04-15 4:22 ` [PATCH v3 2/2] phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424 Kathiravan Thirumoorthy
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Kathiravan Thirumoorthy @ 2025-04-15 4:22 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Dmitry Baryshkov,
Varadarajan Narayanan
Cc: linux-arm-msm, linux-phy, linux-kernel, Kathiravan Thirumoorthy
With the current settings, compliance tests especially eye diagram
(Host High-speed Signal Quality) tests are failing. Reuse the IPQ6018
settings to overcome this issue, as mentioned in the Hardware Design
Document.
So revert the change which introduced the new settings and reuse the
IPQ6018 settings in the subsequent patch.
Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424")
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
drivers/phy/qualcomm/phy-qcom-qusb2.c | 28 ----------------------------
1 file changed, 28 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
index 1f5f7df14d5a2ff041fe15aaeb6ec5ce52ab2a81..81b9e9349c3ebb4d303cb040b5c913336bb6b6d6 100644
--- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
@@ -151,21 +151,6 @@ static const struct qusb2_phy_init_tbl ipq6018_init_tbl[] = {
QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9F),
};
-static const struct qusb2_phy_init_tbl ipq5424_init_tbl[] = {
- QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL, 0x14),
- QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0x00),
- QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0x53),
- QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE4, 0xc3),
- QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TUNE, 0x30),
- QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL1, 0x79),
- QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL2, 0x21),
- QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE5, 0x00),
- QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00),
- QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TEST2, 0x14),
- QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TEST, 0x80),
- QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f),
-};
-
static const struct qusb2_phy_init_tbl qcs615_init_tbl[] = {
QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0xc8),
QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0xb3),
@@ -359,16 +344,6 @@ static const struct qusb2_phy_cfg ipq6018_phy_cfg = {
.autoresume_en = BIT(0),
};
-static const struct qusb2_phy_cfg ipq5424_phy_cfg = {
- .tbl = ipq5424_init_tbl,
- .tbl_num = ARRAY_SIZE(ipq5424_init_tbl),
- .regs = ipq6018_regs_layout,
-
- .disable_ctrl = POWER_DOWN,
- .mask_core_ready = PLL_LOCKED,
- .autoresume_en = BIT(0),
-};
-
static const struct qusb2_phy_cfg qcs615_phy_cfg = {
.tbl = qcs615_init_tbl,
.tbl_num = ARRAY_SIZE(qcs615_init_tbl),
@@ -954,9 +929,6 @@ static const struct phy_ops qusb2_phy_gen_ops = {
static const struct of_device_id qusb2_phy_of_match_table[] = {
{
- .compatible = "qcom,ipq5424-qusb2-phy",
- .data = &ipq5424_phy_cfg,
- }, {
.compatible = "qcom,ipq6018-qusb2-phy",
.data = &ipq6018_phy_cfg,
}, {
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v3 2/2] phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424
2025-04-15 4:22 [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424 Kathiravan Thirumoorthy
2025-04-15 4:22 ` [PATCH v3 1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424" Kathiravan Thirumoorthy
@ 2025-04-15 4:22 ` Kathiravan Thirumoorthy
2025-04-15 8:07 ` Dmitry Baryshkov
2025-04-30 16:43 ` [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY " Kathiravan Thirumoorthy
2025-05-14 11:37 ` Vinod Koul
3 siblings, 1 reply; 6+ messages in thread
From: Kathiravan Thirumoorthy @ 2025-04-15 4:22 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Dmitry Baryshkov,
Varadarajan Narayanan
Cc: linux-arm-msm, linux-phy, linux-kernel, Kathiravan Thirumoorthy
With the settings used in the commit 9c56a1de296e ("phy: qcom-qusb2: add
QUSB2 support for IPQ5424"), compliance test cases especially
eye-diagram (Host High-speed Signal Quality) tests are failing.
Reuse the IPQ6018 settings for IPQ5424 as mentioned in the Hardware
Design Document which helps to meet all the complaince requirement test
cases.
Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424")
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
index 81b9e9349c3ebb4d303cb040b5c913336bb6b6d6..49c37c53b38e70db2a1591081a1a12db7092555d 100644
--- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
@@ -929,6 +929,9 @@ static const struct phy_ops qusb2_phy_gen_ops = {
static const struct of_device_id qusb2_phy_of_match_table[] = {
{
+ .compatible = "qcom,ipq5424-qusb2-phy",
+ .data = &ipq6018_phy_cfg,
+ }, {
.compatible = "qcom,ipq6018-qusb2-phy",
.data = &ipq6018_phy_cfg,
}, {
--
2.34.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424
2025-04-15 4:22 [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424 Kathiravan Thirumoorthy
2025-04-15 4:22 ` [PATCH v3 1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424" Kathiravan Thirumoorthy
2025-04-15 4:22 ` [PATCH v3 2/2] phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424 Kathiravan Thirumoorthy
@ 2025-04-30 16:43 ` Kathiravan Thirumoorthy
2025-05-14 11:37 ` Vinod Koul
3 siblings, 0 replies; 6+ messages in thread
From: Kathiravan Thirumoorthy @ 2025-04-30 16:43 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Dmitry Baryshkov,
Varadarajan Narayanan
Cc: linux-arm-msm, linux-phy, linux-kernel
On 4/15/2025 9:52 AM, Kathiravan Thirumoorthy wrote:
> With the current settings, compliance tests are failing, especially eye
> diagram (Host High-speed Signal Quality) tests. Reuse the IPQ6018
> settings, as mentioned in the Hardware Design Document.
>
> Merge Strategy:
> --------------
> Both the patch in the series should be merged together to avoid breaking
> the USB feature.
Gentle Reminder...
>
> --
> Changes in v3:
> - s/complaince/compliance (Mukesh)
> - s/design team/Hardware Design Document (Mukesh)
> - Link to v2: https://lore.kernel.org/r/20250414-revert_hs_phy_settings-v2-0-25086e20a3a3@oss.qualcomm.com
>
> Changes in V2
> - Splitted the patch into 2 patches, first revert the commit and
> then reuse the IPQ6018 data (Vinod K)
> - Dropped the R-b tag from Dmitry
> - Link to v1 -
> https://lore.kernel.org/linux-arm-msm/20250407-revert_hs_phy_settings-v1-1-ec94e316ea19@oss.qualcomm.com/
>
> ---
> Kathiravan Thirumoorthy (2):
> Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
> phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424
>
> drivers/phy/qualcomm/phy-qcom-qusb2.c | 27 +--------------------------
> 1 file changed, 1 insertion(+), 26 deletions(-)
> ---
> base-commit: b425262c07a6a643ebeed91046e161e20b944164
> change-id: 20250414-revert_hs_phy_settings-47643d2c75ba
>
> Best regards,
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424
2025-04-15 4:22 [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424 Kathiravan Thirumoorthy
` (2 preceding siblings ...)
2025-04-30 16:43 ` [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY " Kathiravan Thirumoorthy
@ 2025-05-14 11:37 ` Vinod Koul
3 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2025-05-14 11:37 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Dmitry Baryshkov, Varadarajan Narayanan,
Kathiravan Thirumoorthy
Cc: linux-arm-msm, linux-phy, linux-kernel
On Tue, 15 Apr 2025 09:52:49 +0530, Kathiravan Thirumoorthy wrote:
> With the current settings, compliance tests are failing, especially eye
> diagram (Host High-speed Signal Quality) tests. Reuse the IPQ6018
> settings, as mentioned in the Hardware Design Document.
>
> Merge Strategy:
> --------------
> Both the patch in the series should be merged together to avoid breaking
> the USB feature.
>
> [...]
Applied, thanks!
[1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
commit: 8a040e13afd94a1f91acaf8e0505769d4f7f5af4
[2/2] phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424
commit: 25c36b54eafc98b3ef004e2037cea1328d9b8bc5
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread