From: Krzysztof Kozlowski <krzk@kernel.org>
To: Amit Singh <quic_amitsi@quicinc.com>
Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
kishon@kernel.org, lumag@kernel.org, neil.armstrong@linaro.org,
quic_wcheng@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_riteshk@quicinc.com,
quic_rajeevny@quicinc.com, quic_vproddut@quicinc.com
Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom: qmp-combo: add support for vdda-aux regulator
Date: Tue, 11 Nov 2025 08:58:52 +0100 [thread overview]
Message-ID: <20251111-innocent-affable-saluki-2bf8bb@kuoka> (raw)
In-Reply-To: <20251110115806.2379442-2-quic_amitsi@quicinc.com>
On Mon, Nov 10, 2025 at 05:28:04PM +0530, Amit Singh wrote:
> Add support for the "vdda-aux" regulator in the QMP PHY binding, with
> an enable_load of 36000 µA. Managing this auxiliary rail in the driver
> allows proper power configuration on platforms that provide the supply,
What is has to do anything with the driver? Why are you documenting the
driver?
I understand this that there is no such supply in the hardware and you
just poke to someone else's supply.
> improving PHY stability.
>
> This change is a no-op on platforms that do not define the "vdda-aux"
> regulator.
Which platforms are these? Your patch claims here that all of the
platforms define vdda-aux, because you did not constrain it per variant.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-11-11 7:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 11:58 [PATCH 0/3] add vdda-aux regulator support for QMP PHY on QCS6490 Amit Singh
2025-11-10 11:58 ` [PATCH 1/3] dt-bindings: phy: qcom: qmp-combo: add support for vdda-aux regulator Amit Singh
2025-11-11 7:58 ` Krzysztof Kozlowski [this message]
2025-11-10 11:58 ` [PATCH 2/3] phy: qcom: qmp-combo: add " Amit Singh
2025-11-10 11:58 ` [PATCH 3/3] arm64: dts: qcom: qcs6490-rb3gen2: add vdda-aux supply for USB QMP PHY Amit Singh
2025-11-10 12:04 ` [PATCH 0/3] add vdda-aux regulator support for QMP PHY on QCS6490 Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111-innocent-affable-saluki-2bf8bb@kuoka \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_amitsi@quicinc.com \
--cc=quic_rajeevny@quicinc.com \
--cc=quic_riteshk@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox