[PATCH 0/3] add vdda-aux regulator support for QMP PHY on QCS6490

[PATCH 0/3] add vdda-aux regulator support for QMP PHY on QCS6490

[Amit Singh]

The `vdda-aux` supply is necessary for proper power sequencing and reliable
USB enumeration on platforms that provide this rail.

This series adds support for the `vdda-aux` regulator to the QMP PHY driver
and updates the QCS6490 RB3 Gen2 device tree to provide the required
auxiliary 3.0 V rail for stable USB PHY operation.
Platforms that do not define `vdda-aux` remain unaffected.

Tested on RB3 Gen2 (QCS6490) platform to ensure proper USB enumeration and
PHY stability.

Amit Singh (3):
  dt-bindings: phy: qcom: qmp-combo: add support for vdda-aux regulator
  phy: qcom: qmp-combo: add vdda-aux regulator
  arm64: dts: qcom: qcs6490-rb3gen2: add vdda-aux supply for USB QMP PHY

 .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml  | 2 ++
 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts                    | 1 +
 drivers/phy/qualcomm/phy-qcom-qmp-combo.c                       | 1 +
 3 files changed, 4 insertions(+)

-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

[PATCH 1/3] dt-bindings: phy: qcom: qmp-combo: add support for vdda-aux regulator

[Amit Singh]

Add support for the "vdda-aux" regulator in the QMP PHY binding, with
an enable_load of 36000 µA. Managing this auxiliary rail in the driver
allows proper power configuration on platforms that provide the supply,
improving PHY stability.

This change is a no-op on platforms that do not define the "vdda-aux"
regulator.

Signed-off-by: Amit Singh <quic_amitsi@quicinc.com>
---
 .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml  | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
index c8bc512df08b..9a9051735314 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
@@ -59,6 +59,8 @@ properties:
       - const: phy
       - const: common
 
+  vdda-aux-supply: true
+
   vdda-phy-supply: true
 
   vdda-pll-supply: true
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH 1/3] dt-bindings: phy: qcom: qmp-combo: add support for vdda-aux regulator

[Krzysztof Kozlowski]

On Mon, Nov 10, 2025 at 05:28:04PM +0530, Amit Singh wrote:
> Add support for the "vdda-aux" regulator in the QMP PHY binding, with
> an enable_load of 36000 µA. Managing this auxiliary rail in the driver
> allows proper power configuration on platforms that provide the supply,

What is has to do anything with the driver? Why are you documenting the
driver?

I understand this that there is no such supply in the hardware and you
just poke to someone else's supply.


> improving PHY stability.
> 
> This change is a no-op on platforms that do not define the "vdda-aux"
> regulator.

Which platforms are these? Your patch claims here that all of the
platforms define vdda-aux, because you did not constrain it per variant.

Best regards,
Krzysztof


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

[PATCH 2/3] phy: qcom: qmp-combo: add vdda-aux regulator

[Amit Singh]

Add "vdda-aux" to the QMP PHY regulator list with an enable_load of
36000 µA, allowing the driver to manage the auxiliary supply when
present in device trees.

This aligns power sequencing with existing "vdda-phy" and
"vdda-pll" rails, and is required for platforms that depend on
the auxiliary 3.0 V rail for stable QMP operation. Platforms that
do not define "vdda-aux" remain unaffected.

Signed-off-by: Amit Singh <quic_amitsi@quicinc.com>
---
 drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index 7b5af30f1d02..1ad0f06ae262 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -1649,6 +1649,7 @@ struct qmp_regulator_data {
 };
 
 static struct qmp_regulator_data qmp_phy_vreg_l[] = {
+	{ .name = "vdda-aux", .enable_load = 36000 },
 	{ .name = "vdda-phy", .enable_load = 21800 },
 	{ .name = "vdda-pll", .enable_load = 36000 },
 };
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

[PATCH 3/3] arm64: dts: qcom: qcs6490-rb3gen2: add vdda-aux supply for USB QMP PHY

[Amit Singh]

Add the missing vdda-aux-supply to the USB QMP PHY node on the
RB3 Gen2 (QCS6490) platform. The auxiliary 3.0 V rail is required for
stable PHY operation and proper power configuration.

Providing this supply avoids fallback to dummy regulators and helps
ensure reliable USB enumeration.

Signed-off-by: Amit Singh <quic_amitsi@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index c146161e4bb4..441b5d9d377c 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -1367,6 +1367,7 @@ &usb_1_hsphy {
 };
 
 &usb_1_qmpphy {
+	vdda-aux-supply = <&vreg_l7c_3p0>;
 	vdda-phy-supply = <&vreg_l6b_1p2>;
 	vdda-pll-supply = <&vreg_l1b_0p912>;
 
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH 0/3] add vdda-aux regulator support for QMP PHY on QCS6490

[Konrad Dybcio]

On 11/10/25 12:58 PM, Amit Singh wrote:
> The `vdda-aux` supply is necessary for proper power sequencing and reliable
> USB enumeration on platforms that provide this rail.
> 
> This series adds support for the `vdda-aux` regulator to the QMP PHY driver
> and updates the QCS6490 RB3 Gen2 device tree to provide the required
> auxiliary 3.0 V rail for stable USB PHY operation.
> Platforms that do not define `vdda-aux` remain unaffected.
> 
> Tested on RB3 Gen2 (QCS6490) platform to ensure proper USB enumeration and
> PHY stability.

I don't see this vreg going to the SoC on the schematics.

What is it actually powering?

Konrad

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy