* Re: [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100)
2026-01-11 8:25 [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) Val Packett
@ 2026-01-11 19:47 ` Dmitry Baryshkov
2026-01-12 9:25 ` Konrad Dybcio
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2026-01-11 19:47 UTC (permalink / raw)
To: Val Packett
Cc: Vinod Koul, Neil Armstrong, Abel Vesa, Abel Vesa, linux-arm-msm,
linux-phy, linux-kernel
On Sun, Jan 11, 2026 at 05:25:59AM -0300, Val Packett wrote:
> For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a
> stub implementation was added for the v4 of the hardware. However it
> was omitted for the v6, causing a NULL pointer dereference oops on
> Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub.
>
> Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support")
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> Signed-off-by: Val Packett <val@packett.cool>
> ---
> v2: pull R-b, reuse v4 function as suggested by Konrad
> v1: https://lore.kernel.org/all/20260109045214.5983-1-val@packett.cool/
>
> drivers/phy/qualcomm/phy-qcom-edp.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100)
2026-01-11 8:25 [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) Val Packett
2026-01-11 19:47 ` Dmitry Baryshkov
@ 2026-01-12 9:25 ` Konrad Dybcio
2026-01-13 7:23 ` Yijie Yang
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2026-01-12 9:25 UTC (permalink / raw)
To: Val Packett, Vinod Koul, Neil Armstrong, Abel Vesa,
Dmitry Baryshkov
Cc: Abel Vesa, linux-arm-msm, linux-phy, linux-kernel
On 1/11/26 9:25 AM, Val Packett wrote:
> For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a
> stub implementation was added for the v4 of the hardware. However it
> was omitted for the v6, causing a NULL pointer dereference oops on
> Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub.
>
> Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support")
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> Signed-off-by: Val Packett <val@packett.cool>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100)
2026-01-11 8:25 [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) Val Packett
2026-01-11 19:47 ` Dmitry Baryshkov
2026-01-12 9:25 ` Konrad Dybcio
@ 2026-01-13 7:23 ` Yijie Yang
2026-01-13 8:10 ` Neil Armstrong
2026-01-14 14:01 ` Vinod Koul
4 siblings, 0 replies; 6+ messages in thread
From: Yijie Yang @ 2026-01-13 7:23 UTC (permalink / raw)
To: Val Packett, Vinod Koul, Neil Armstrong, Abel Vesa,
Dmitry Baryshkov
Cc: Abel Vesa, linux-arm-msm, linux-phy, linux-kernel, yijie.yang
On 1/11/2026 4:25 PM, Val Packett wrote:
> For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a
> stub implementation was added for the v4 of the hardware. However it
> was omitted for the v6, causing a NULL pointer dereference oops on
> Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub.
>
> Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support")
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> Signed-off-by: Val Packett <val@packett.cool>
> ---
> v2: pull R-b, reuse v4 function as suggested by Konrad
> v1: https://lore.kernel.org/all/20260109045214.5983-1-val@packett.cool/
>
> drivers/phy/qualcomm/phy-qcom-edp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
> index 13feab99feec..7372de05a0b8 100644
> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
> @@ -758,6 +758,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v6 = {
> .com_power_on = qcom_edp_phy_power_on_v6,
> .com_resetsm_cntrl = qcom_edp_phy_com_resetsm_cntrl_v6,
> .com_bias_en_clkbuflr = qcom_edp_com_bias_en_clkbuflr_v6,
> + .com_clk_fwd_cfg = qcom_edp_com_clk_fwd_cfg_v4,
> .com_configure_pll = qcom_edp_com_configure_pll_v6,
> .com_configure_ssc = qcom_edp_com_configure_ssc_v6,
> };
Tested-by: Yijie Yang <yijie.yang@oss.qualcomm.com> # Purwa-IoT-EVK
--
Best Regards,
Yijie
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100)
2026-01-11 8:25 [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) Val Packett
` (2 preceding siblings ...)
2026-01-13 7:23 ` Yijie Yang
@ 2026-01-13 8:10 ` Neil Armstrong
2026-01-14 14:01 ` Vinod Koul
4 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2026-01-13 8:10 UTC (permalink / raw)
To: Val Packett, Vinod Koul, Abel Vesa, Dmitry Baryshkov
Cc: Abel Vesa, linux-arm-msm, linux-phy, linux-kernel
On 1/11/26 09:25, Val Packett wrote:
> For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a
> stub implementation was added for the v4 of the hardware. However it
> was omitted for the v6, causing a NULL pointer dereference oops on
> Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub.
>
> Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support")
> Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> Signed-off-by: Val Packett <val@packett.cool>
> ---
> v2: pull R-b, reuse v4 function as suggested by Konrad
> v1: https://lore.kernel.org/all/20260109045214.5983-1-val@packett.cool/
>
> drivers/phy/qualcomm/phy-qcom-edp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
> index 13feab99feec..7372de05a0b8 100644
> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
> @@ -758,6 +758,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v6 = {
> .com_power_on = qcom_edp_phy_power_on_v6,
> .com_resetsm_cntrl = qcom_edp_phy_com_resetsm_cntrl_v6,
> .com_bias_en_clkbuflr = qcom_edp_com_bias_en_clkbuflr_v6,
> + .com_clk_fwd_cfg = qcom_edp_com_clk_fwd_cfg_v4,
> .com_configure_pll = qcom_edp_com_configure_pll_v6,
> .com_configure_ssc = qcom_edp_com_configure_ssc_v6,
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100)
2026-01-11 8:25 [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) Val Packett
` (3 preceding siblings ...)
2026-01-13 8:10 ` Neil Armstrong
@ 2026-01-14 14:01 ` Vinod Koul
4 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2026-01-14 14:01 UTC (permalink / raw)
To: Neil Armstrong, Abel Vesa, Dmitry Baryshkov, Val Packett
Cc: Abel Vesa, linux-arm-msm, linux-phy, linux-kernel
On Sun, 11 Jan 2026 05:25:59 -0300, Val Packett wrote:
> For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a
> stub implementation was added for the v4 of the hardware. However it
> was omitted for the v6, causing a NULL pointer dereference oops on
> Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub.
>
>
Applied, thanks!
[1/1] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100)
commit: 70812056fbfb9348788e35b7641ff959b711840e
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread