Re: [PATCH v3 3/5] arm64: dts: qcom: Add Shikra CQ2390M SoM platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to add PM8005 PMIC regulator definitions, but the patch explicitly disables the PM8005 regulators and provides no configuration.
--

commit b8207cdfd80924e291ee52448a105708aa7b6a09
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

arm64: dts: qcom: Add Shikra CQ2390M SoM platform

This commit adds the device tree include for the CQ2390M variant of the
Shikra System-on-Module. It integrates the Shikra SoC and includes PMIC
regulator configurations for the retail SoM.

> The DTSI includes the common shikra.dtsi, adds PM4125 and PM8005 PMIC
> regulator definitions specific to this variant.

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi b/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi

[ ... ]

> +&pm8005_regulators {
> +	status = "disabled";
> +};

[Severity: Medium]
Is the commit message inaccurate, or are the definitions for the PM8005
regulators missing from this patch?

The commit message states that PM8005 PMIC regulator definitions are
added, but the code explicitly disables them without providing any
configuration. If the SoM variant requires the PM8005 regulators to power
hardware components, will leaving them disabled result in runtime failures?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522-shikra-dt-v3-0-80ffde8a3dc4@oss.qualcomm.com?part=3

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy