Re: [PATCH v3 5/5] arm64: dts: qcom: Add Shikra EVK boards

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The device tree file shikra-cqs-evk.dts incorrectly includes the CQM SoM device tree (shikra-cqm-som.dtsi) instead of the expected CQS SoM device tree (shikra-cqs-som.dtsi).
--

commit cb9ff9c76f4ee019113138237f57794fa621d71f
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

arm64: dts: qcom: Add Shikra EVK boards

This commit adds device trees for the Shikra EVK platform, combining
Shikra SoM variants with a common carrier board. It introduces three EVK
boards: CQM (retail with modem), CQS (retail without modem), and IQS
(industrial without modem).

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> new file mode 100644
> index 0000000000000..b3f19a64d7aed
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
> @@ -0,0 +1,40 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +/dts-v1/;
> +
> +#include "shikra-cqm-som.dtsi"

[Severity: High]
The commit message states that shikra-cqs-evk.dts pairs with the CQ2390S
SoM (retail, without modem). Does this file include the incorrect SoM dtsi?

Including shikra-cqm-som.dtsi here seems like it would pull in the hardware
description of the modem-enabled CQM SoM instead of the expected CQS variant.

Could this cause boot issues or lead to loading drivers for hardware that
isn't actually present on the CQS board?

> +#include "shikra-evk.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. Shikra CQS EVK";
> +	compatible = "qcom,shikra-cqs-evk", "qcom,shikra-cqs-som", "qcom,shikra";

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522-shikra-dt-v3-0-80ffde8a3dc4@oss.qualcomm.com?part=5

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy