Re: [PATCH 4/7] dt-bindings: usb: ti,musb-am33xx: Convert to DT schema - sashiko-bot

From: sashiko-bot@kernel.org
To: "Bhargav Joshi" <j.bhargav.u@gmail.com>
Cc: neil.armstrong@linaro.org, dmaengine@vger.kernel.org,
	olteanv@gmail.com, robh@kernel.org, conor+dt@kernel.org,
	Frank.Li@kernel.org, vkoul@kernel.org,
	devicetree@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH 4/7] dt-bindings: usb: ti,musb-am33xx: Convert to DT schema
Date: Mon, 17 Aug 2026 21:58:28 +0000	[thread overview]
Message-ID: <20260817215828.978C41F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818-ti-am33-usb-v1-4-69ac5f92df45@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The custom vendor-specific property `mentor,ram-bits` is missing a type definition reference (`$ref`), which will cause device tree schema validation to fail.
--

--- Patch [4]: [PATCH 4/7] dt-bindings: usb: ti,musb-am33xx: Convert to DT schema ---
commit 8d75d797452b1f785af4636b0cd55212a95b505a
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: usb: ti,musb-am33xx: Convert to DT schema

This commit converts the TI AM33xx MUSB text bindings to DT schema format.
It includes modifications to support optional vbus interrupts and natively
supported multipoint setups, as well as adding hardware-specific properties.

> diff --git a/Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml b/Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml
> new file mode 100644
> index 0000000000000..05909d5ca3d2d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml

[ ... ]

> +  mentor,num-eps:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Specifies the number of endpoints.
> +    const: 16
> +
> +  mentor,ram-bits:
> +    description: Specifies the ram address size.
> +    const: 12

[Severity: Low]
Does this property need a type definition reference? 

Unlike its sibling properties (such as mentor,num-eps and mentor,power), 
mentor,ram-bits is missing a $ref to a standard DT type. Because it is a 
custom vendor-specific property, lacking a type reference like 
$ref: /schemas/types.yaml#/definitions/uint32 typically causes 
dt_binding_check to fail with a missing type definition error.

> +
> +  mentor,power:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Controller supply capacity (in mA) when operating in host mode.
> +    const: 500

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818-ti-am33-usb-v1-0-69ac5f92df45@gmail.com?part=4

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy