Re: [PATCH net-next v5 05/11] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `xpcs` node omits the `phys` and `phy-names` properties, which are unconditionally required by the DT binding schema.
- [Low] The `status` property is used in the `ethernet-pcs-mii@[0-3]` child nodes, but it is not permitted by the `rockchip,rk3568-xpcs.yaml` schema.
--

commit 2dc66bd193ed0eb637b2ea9fc03e4b482b419260
Author: Coia Prant <coiaprant@gmail.com>

arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

This commit adds the XPCS device node and its pcs-mii sub-nodes to the 
RK3568 SoC device tree to support 1000BASE-X, SGMII, and QSGMII interfaces. 
It also introduces two fixed-clock nodes providing the 125 MHz reference 
clock for the GMACs.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -110,6 +110,51 @@ sata0: sata@fc000000 {
>  		status = "disabled";
>  	};
>  
> +	xpcs: ethernet-pcs@fda00000 {
> +		compatible = "rockchip,rk3568-xpcs";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x0 0xfda00000 0x0 0x200000>;
> +		clocks = <&cru PCLK_XPCS>, <&cru CLK_XPCS_EEE>;
> +		clock-names = "csr", "eee";
> +		power-domains = <&power RK3568_PD_PIPE>;
> +		status = "disabled";

[Severity: Low]
Does this node need to include the phys and phy-names properties?
The DT binding schema for rockchip,rk3568-xpcs unconditionally requires
these properties. Omitting them here might cause make dtbs_check to fail
with validation warnings on boards that do not override and populate this
node.

> +
> +		xpcs_mii0: ethernet-pcs-mii@0 {
> +			reg = <0>;
> +			status = "disabled";

[Severity: Low]
Is the status property permitted in these child nodes?
The schema for ethernet-pcs-mii@[0-3] uses additionalProperties: false
and restricts properties to just reg. Including status here will likely
trigger validation warnings during make dtbs_check.

> +		};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260913185849.907479-1-coiaprant@gmail.com?part=5

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy