Re: [PATCH net-next v5 09/11] net: stmmac: dwmac-rk: add SGMII support for RK3568 - sashiko-bot

From: sashiko-bot@kernel.org
To: "Coia Prant" <coiaprant@gmail.com>
Cc: neil.armstrong@linaro.org, conor+dt@kernel.org, robh@kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	olteanv@gmail.com, wsa+renesas@sang-engineering.com,
	vkoul@kernel.org
Subject: Re: [PATCH net-next v5 09/11] net: stmmac: dwmac-rk: add SGMII support for RK3568
Date: Mon, 14 Sep 2026 19:44:24 +0000	[thread overview]
Message-ID: <20260914194424.9490A1F00899@smtp.kernel.org> (raw)
In-Reply-To: <20260913185849.907479-10-coiaprant@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] DWMAC_ROCKCHIP selects PCS_XPCS_ROCKCHIP without inheriting its dependencies, causing Kconfig warnings.
--

commit a034d04f6974ebd2055a96c9de8c8e79f795fefe
Author: Coia Prant <coiaprant@gmail.com>

net: stmmac: dwmac-rk: add SGMII support for RK3568

This commit adds SGMII support for the RK3568 SoC in the dwmac-rk driver.
It introduces callbacks to configure the GMAC GRF register for SGMII mode,
implements PCS initialization to create the XPCS, and configures phylink
for in-band negotiation.

Link: https://dl.radxa.com/rock3/docs/hw/datasheet/Rockchip%20RK3568%20TRM%20Part1%20V1.1-20210301.pdf (Page 386)

> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index ab3c4cf964239..c6559e749c0ce 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -170,6 +170,7 @@ config DWMAC_ROCKCHIP
>  	default ARCH_ROCKCHIP
>  	depends on OF && (ARCH_ROCKCHIP || COMPILE_TEST)
>  	select MFD_SYSCON
> +	select PCS_XPCS_ROCKCHIP

[Severity: Medium]
Does selecting PCS_XPCS_ROCKCHIP under config DWMAC_ROCKCHIP require
inheriting its dependencies?

If a kernel is built with DWMAC_ROCKCHIP enabled, but GENERIC_PHY or
PM_GENERIC_DOMAINS is disabled, this select statement forces PCS_XPCS_ROCKCHIP
to be enabled without its underlying dependencies.

This can cause Kconfig unmet direct dependencies warnings at build time and
potentially lead to silent build failures.

Would it be better to add the required dependencies to DWMAC_ROCKCHIP?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260913185849.907479-1-coiaprant@gmail.com?part=9

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy