Re: [PATCH v17 09/11] arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: missing #phy-cells in CSIPHY nodes breaks phy lookup
--

commit 0d5dc943d2ac26c65efdf11a56970db1bd7ff6f9
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions

This commit adds device tree nodes for the CAMSS and CSIPHY blocks on the
Kaanapali platform. These definitions enable camera pipelines to be configured
and used by board-specific device trees.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> index 3e63e62251089..7a80438bde570 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi

[ ... ]

> @@ -3595,6 +3596,307 @@ usb_dp_qmpphy_dp_in: endpoint {
>  			};
>  		};
>  
> +		camss: isp@9253000 {

[ ... ]

> +		csiphy0: phy@9523000 {
> +			compatible = "qcom,kaanapali-csi2-phy";
> +			reg = <0x0 0x09523000 0x0 0x2000>;

[Severity: Medium]
Does this node need a #phy-cells property? The generic PHY framework requires
this for consumers to successfully probe.

The qcom,kaanapali-csi2-phy compatible binds to a generic PHY provider via
devm_of_phy_provider_register(dev, of_phy_simple_xlate). When a consumer
calls phy_get(), the PHY core invokes of_parse_phandle_with_args() to parse
the reference.

Without #phy-cells = <0>; in this and the other csiphy nodes (csiphy0 through
csiphy5) in arch/arm64/boot/dts/qcom/kaanapali.dtsi, the translation will fail,
leaving the consumer devices non-functional.

> +
> +			clocks = <&camcc CAM_CC_CSIPHY0_CLK>,
> +				 <&camcc CAM_CC_CSI0PHYTIMER_CLK>,
> +				 <&camcc CAM_CC_CORE_AHB_CLK>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928-kaanapali-camss-v17-0-dcf3fd37f76c@oss.qualcomm.com?part=9

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy