Re: [PATCH v17 09/11] arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions

From: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-phy@lists.infradead.org, robh@kernel.org,
	conor+dt@kernel.org, media-ci@linuxtv.org, vkoul@kernel.org,
	neil.armstrong@linaro.org, devicetree@vger.kernel.org,
	olteanv@gmail.com
Subject: Re: [PATCH v17 09/11] arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions
Date: Wed, 30 Sep 2026 22:17:46 +0800	[thread overview]
Message-ID: <dd0ddd6b-f2a3-4f10-9baf-7420e66d6a5d@oss.qualcomm.com> (raw)
In-Reply-To: <20260929061112.51F2C1F000FF@smtp.kernel.org>

On 9/29/2026 2:11 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] dts: missing #phy-cells in CSIPHY nodes breaks phy lookup
> --
> 
> commit 0d5dc943d2ac26c65efdf11a56970db1bd7ff6f9
> Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
> 
> arm64: dts: qcom: kaanapali: Add CAMSS and CSIPHY block definitions
> 
> This commit adds device tree nodes for the CAMSS and CSIPHY blocks on the
> Kaanapali platform. These definitions enable camera pipelines to be configured
> and used by board-specific device trees.
> 
>> diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
>> index 3e63e62251089..7a80438bde570 100644
>> --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi
> 
> [ ... ]
> 
>> @@ -3595,6 +3596,307 @@ usb_dp_qmpphy_dp_in: endpoint {
>>   			};
>>   		};
>>   
>> +		camss: isp@9253000 {
> 
> [ ... ]
> 
>> +		csiphy0: phy@9523000 {
>> +			compatible = "qcom,kaanapali-csi2-phy";
>> +			reg = <0x0 0x09523000 0x0 0x2000>;
> 
> [Severity: Medium]
> Does this node need a #phy-cells property? The generic PHY framework requires
> this for consumers to successfully probe.
> 
> The qcom,kaanapali-csi2-phy compatible binds to a generic PHY provider via
> devm_of_phy_provider_register(dev, of_phy_simple_xlate). When a consumer
> calls phy_get(), the PHY core invokes of_parse_phandle_with_args() to parse
> the reference.
> 
> Without #phy-cells = <0>; in this and the other csiphy nodes (csiphy0 through
> csiphy5) in arch/arm64/boot/dts/qcom/kaanapali.dtsi, the translation will fail,
> leaving the consumer devices non-functional.
> 
>> +
>> +			clocks = <&camcc CAM_CC_CSIPHY0_CLK>,
>> +				 <&camcc CAM_CC_CSI0PHYTIMER_CLK>,
>> +				 <&camcc CAM_CC_CORE_AHB_CLK>;
> 
> [ ... ]
> 

This node style aligns with the x1e80100 example:
https://lore.kernel.org/all/20260917-x1e-camss-csi2-phy-dtsi-v7-4-1a63eb35838b@linaro.org/

Best Regards,
Hangxiang

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy