Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] phy: exynos5-usbdrd: fix error code in probe()
@ 2024-07-08 17:04 Dan Carpenter
  2024-07-08 17:33 ` André Draszik
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Dan Carpenter @ 2024-07-08 17:04 UTC (permalink / raw)
  To: André Draszik
  Cc: Vinod Koul, Kishon Vijay Abraham I, Krzysztof Kozlowski,
	Alim Akhtar, Peter Griffin, Sam Protsenko, Rob Herring, linux-phy,
	linux-arm-kernel, linux-samsung-soc, linux-kernel,
	kernel-janitors

Return negative -ENOMEM instead of positive ENOMEM.

Fixes: 497ddafe915e ("phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/phy/samsung/phy-exynos5-usbdrd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
index df52b78a120b..9cbf90142950 100644
--- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
+++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
@@ -1745,7 +1745,7 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
 					   sizeof(*phy_drd->regulators),
 					   GFP_KERNEL);
 	if (!phy_drd->regulators)
-		return ENOMEM;
+		return -ENOMEM;
 	regulator_bulk_set_supply_names(phy_drd->regulators,
 					drv_data->regulator_names,
 					drv_data->n_regulators);
-- 
2.43.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: exynos5-usbdrd: fix error code in probe()
  2024-07-08 17:04 [PATCH] phy: exynos5-usbdrd: fix error code in probe() Dan Carpenter
@ 2024-07-08 17:33 ` André Draszik
  2024-07-08 18:26 ` Markus Elfring
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: André Draszik @ 2024-07-08 17:33 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Vinod Koul, Kishon Vijay Abraham I, Krzysztof Kozlowski,
	Alim Akhtar, Peter Griffin, Sam Protsenko, Rob Herring, linux-phy,
	linux-arm-kernel, linux-samsung-soc, linux-kernel,
	kernel-janitors

On Mon, 2024-07-08 at 12:04 -0500, Dan Carpenter wrote:
> Return negative -ENOMEM instead of positive ENOMEM.
> 
> Fixes: 497ddafe915e ("phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: André Draszik <andre.draszik@linaro.org>


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: exynos5-usbdrd: fix error code in probe()
  2024-07-08 17:04 [PATCH] phy: exynos5-usbdrd: fix error code in probe() Dan Carpenter
  2024-07-08 17:33 ` André Draszik
@ 2024-07-08 18:26 ` Markus Elfring
  2024-07-08 20:26 ` Sam Protsenko
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2024-07-08 18:26 UTC (permalink / raw)
  To: Dan Carpenter, linux-phy, linux-arm-kernel, linux-samsung-soc,
	André Draszik
  Cc: kernel-janitors, LKML, Alim Akhtar, Kishon Vijay Abraham I,
	Krzysztof Kozlowski, Peter Griffin, Rob Herring, Sam Protsenko,
	Vinod Koul

> Return negative -ENOMEM instead of positive ENOMEM.

Would you like to refer to the function name “exynos5_usbdrd_phy_probe”
in the summary phrase?

Regards,
Markus

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: exynos5-usbdrd: fix error code in probe()
  2024-07-08 17:04 [PATCH] phy: exynos5-usbdrd: fix error code in probe() Dan Carpenter
  2024-07-08 17:33 ` André Draszik
  2024-07-08 18:26 ` Markus Elfring
@ 2024-07-08 20:26 ` Sam Protsenko
  2024-07-09 10:51 ` Peter Griffin
  2024-08-04 17:52 ` Vinod Koul
  4 siblings, 0 replies; 6+ messages in thread
From: Sam Protsenko @ 2024-07-08 20:26 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: André Draszik, Vinod Koul, Kishon Vijay Abraham I,
	Krzysztof Kozlowski, Alim Akhtar, Peter Griffin, Rob Herring,
	linux-phy, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	kernel-janitors

On Mon, Jul 8, 2024 at 12:04 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Return negative -ENOMEM instead of positive ENOMEM.
>
> Fixes: 497ddafe915e ("phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

>  drivers/phy/samsung/phy-exynos5-usbdrd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> index df52b78a120b..9cbf90142950 100644
> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> @@ -1745,7 +1745,7 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
>                                            sizeof(*phy_drd->regulators),
>                                            GFP_KERNEL);
>         if (!phy_drd->regulators)
> -               return ENOMEM;
> +               return -ENOMEM;
>         regulator_bulk_set_supply_names(phy_drd->regulators,
>                                         drv_data->regulator_names,
>                                         drv_data->n_regulators);
> --
> 2.43.0
>

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: exynos5-usbdrd: fix error code in probe()
  2024-07-08 17:04 [PATCH] phy: exynos5-usbdrd: fix error code in probe() Dan Carpenter
                   ` (2 preceding siblings ...)
  2024-07-08 20:26 ` Sam Protsenko
@ 2024-07-09 10:51 ` Peter Griffin
  2024-08-04 17:52 ` Vinod Koul
  4 siblings, 0 replies; 6+ messages in thread
From: Peter Griffin @ 2024-07-09 10:51 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: André Draszik, Vinod Koul, Kishon Vijay Abraham I,
	Krzysztof Kozlowski, Alim Akhtar, Sam Protsenko, Rob Herring,
	linux-phy, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	kernel-janitors

On Mon, 8 Jul 2024 at 18:04, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> Return negative -ENOMEM instead of positive ENOMEM.
>
> Fixes: 497ddafe915e ("phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---

Reviewed-by:  Peter Griffin <peter.griffin@linaro.org>

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] phy: exynos5-usbdrd: fix error code in probe()
  2024-07-08 17:04 [PATCH] phy: exynos5-usbdrd: fix error code in probe() Dan Carpenter
                   ` (3 preceding siblings ...)
  2024-07-09 10:51 ` Peter Griffin
@ 2024-08-04 17:52 ` Vinod Koul
  4 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2024-08-04 17:52 UTC (permalink / raw)
  To: André Draszik, Dan Carpenter
  Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Alim Akhtar,
	Peter Griffin, Sam Protsenko, Rob Herring, linux-phy,
	linux-arm-kernel, linux-samsung-soc, linux-kernel,
	kernel-janitors


On Mon, 08 Jul 2024 12:04:33 -0500, Dan Carpenter wrote:
> Return negative -ENOMEM instead of positive ENOMEM.
> 
> 

Applied, thanks!

[1/1] phy: exynos5-usbdrd: fix error code in probe()
      commit: 3a07703a523045cbdb0a5fa5e0902a9145ee43e9

Best regards,
-- 
Vinod Koul <vkoul@kernel.org>


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-04 17:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-08 17:04 [PATCH] phy: exynos5-usbdrd: fix error code in probe() Dan Carpenter
2024-07-08 17:33 ` André Draszik
2024-07-08 18:26 ` Markus Elfring
2024-07-08 20:26 ` Sam Protsenko
2024-07-09 10:51 ` Peter Griffin
2024-08-04 17:52 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox