[PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only

[PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

phy-brcm-usb has some conditional init code required on selected brcmstb
devices. Execution of that code depends on family / product detected by
brcmstb soc code.

For ARCH_BCM4908 brcmstb soc code always return 0 values as ids. Don't
bother selecting & compiling that redundant driver.

Depends-on: 149ae80b1d50 ("soc: bcm: brcmstb: add stubs for getting platform IDs")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 drivers/phy/broadcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
index 09256339bd04..fd92b73b7109 100644
--- a/drivers/phy/broadcom/Kconfig
+++ b/drivers/phy/broadcom/Kconfig
@@ -94,7 +94,7 @@ config PHY_BRCM_USB
 	depends on ARCH_BCM4908 || ARCH_BRCMSTB || COMPILE_TEST
 	depends on OF
 	select GENERIC_PHY
-	select SOC_BRCMSTB
+	select SOC_BRCMSTB if ARCH_BRCMSTB
 	default ARCH_BCM4908
 	default ARCH_BRCMSTB
 	help
-- 
2.26.2


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only

[Florian Fainelli]

On 3/5/2021 07:24, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> phy-brcm-usb has some conditional init code required on selected brcmstb
> devices. Execution of that code depends on family / product detected by
> brcmstb soc code.
> 
> For ARCH_BCM4908 brcmstb soc code always return 0 values as ids. Don't
> bother selecting & compiling that redundant driver.
> 
> Depends-on: 149ae80b1d50 ("soc: bcm: brcmstb: add stubs for getting platform IDs")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only

[Rafał Miłecki]

Sending reply-to-all after subscribing to the linux-phy@ ML.

On 05.03.2021 16:24, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> phy-brcm-usb has some conditional init code required on selected brcmstb
> devices. Execution of that code depends on family / product detected by
> brcmstb soc code.
> 
> For ARCH_BCM4908 brcmstb soc code always return 0 values as ids. Don't
> bother selecting & compiling that redundant driver.
> 
> Depends-on: 149ae80b1d50 ("soc: bcm: brcmstb: add stubs for getting platform IDs")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>   drivers/phy/broadcom/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
> index 09256339bd04..fd92b73b7109 100644
> --- a/drivers/phy/broadcom/Kconfig
> +++ b/drivers/phy/broadcom/Kconfig
> @@ -94,7 +94,7 @@ config PHY_BRCM_USB
>   	depends on ARCH_BCM4908 || ARCH_BRCMSTB || COMPILE_TEST
>   	depends on OF
>   	select GENERIC_PHY
> -	select SOC_BRCMSTB
> +	select SOC_BRCMSTB if ARCH_BRCMSTB
>   	default ARCH_BCM4908
>   	default ARCH_BRCMSTB
>   	help
> 

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: phy-brcm-usb: select SOC_BRCMSTB on brcmstb only

[Vinod Koul]

On 05-03-21, 16:24, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> phy-brcm-usb has some conditional init code required on selected brcmstb
> devices. Execution of that code depends on family / product detected by
> brcmstb soc code.
> 
> For ARCH_BCM4908 brcmstb soc code always return 0 values as ids. Don't
> bother selecting & compiling that redundant driver.

Applied, thanks

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy