* [PATCH] phy: starfive: fix error code in probe
@ 2023-07-18 7:02 Dan Carpenter
2023-07-24 10:55 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-07-18 7:02 UTC (permalink / raw)
To: Minda Chen
Cc: Vinod Koul, Kishon Vijay Abraham I, Roger Quadros, linux-phy,
kernel-janitors
This is using the wrong pointer, "phy->regs" vs "phy->phy".
Fixes: 26cea0e28057 ("phy: starfive: Add JH7110 PCIE 2.0 PHY driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/phy/starfive/phy-jh7110-pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/starfive/phy-jh7110-pcie.c b/drivers/phy/starfive/phy-jh7110-pcie.c
index cbe79c1f59d3..734c8e007727 100644
--- a/drivers/phy/starfive/phy-jh7110-pcie.c
+++ b/drivers/phy/starfive/phy-jh7110-pcie.c
@@ -151,7 +151,7 @@ static int jh7110_pcie_phy_probe(struct platform_device *pdev)
phy->phy = devm_phy_create(dev, NULL, &jh7110_pcie_phy_ops);
if (IS_ERR(phy->phy))
- return dev_err_probe(dev, PTR_ERR(phy->regs),
+ return dev_err_probe(dev, PTR_ERR(phy->phy),
"Failed to map phy base\n");
phy->sys_syscon =
--
2.39.2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: starfive: fix error code in probe
2023-07-18 7:02 [PATCH] phy: starfive: fix error code in probe Dan Carpenter
@ 2023-07-24 10:55 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2023-07-24 10:55 UTC (permalink / raw)
To: Minda Chen, Dan Carpenter
Cc: Kishon Vijay Abraham I, Roger Quadros, linux-phy, kernel-janitors
On Tue, 18 Jul 2023 10:02:49 +0300, Dan Carpenter wrote:
> This is using the wrong pointer, "phy->regs" vs "phy->phy".
>
>
Applied, thanks!
[1/1] phy: starfive: fix error code in probe
commit: 86fe3e9f4c635cf740b31161ee35aed4a78e03f9
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-24 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-18 7:02 [PATCH] phy: starfive: fix error code in probe Dan Carpenter
2023-07-24 10:55 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox