From: Xin Liu <quic_liuxin@quicinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
"Andy Gross" <agross@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<quic_jiegan@quicinc.com>, <quic_aiquny@quicinc.com>,
<quic_tingweiz@quicinc.com>, <quic_sayalil@quicinc.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: qcs615-ride: Enable UFS node
Date: Mon, 9 Dec 2024 16:31:34 +0800 [thread overview]
Message-ID: <66654b75-cfc2-470c-90e9-76da5e2a1f47@quicinc.com> (raw)
In-Reply-To: <20241202144844.erqdn5ltsblyhy27@thinkpad>
在 2024/12/2 22:48, Manivannan Sadhasivam 写道:
> On Fri, Nov 22, 2024 at 02:44:28PM +0800, Xin Liu wrote:
>> From: Sayali Lokhande <quic_sayalil@quicinc.com>
>>
>> Enable UFS on the Qualcomm QCS615 Ride platform.
>>
>> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> One question below.
>
>> ---
>> arch/arm64/boot/dts/qcom/qcs615-ride.dts | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index ee6cab3924a6..79634646350b 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -214,6 +214,22 @@ &uart0 {
>> status = "okay";
>> };
>>
>> +&ufs_mem_hc {
>
> No 'reset-gpios' to reset the UFS device?
I will check it, and fix it next version.
>
> - Mani
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2024-12-09 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 6:44 [PATCH v3 0/3] Enable UFS on QCS615 Xin Liu
2024-11-22 6:44 ` [PATCH v3 1/3] dt-bindings: ufs: qcom: Add UFS Host Controller for QCS615 Xin Liu
2024-11-22 6:44 ` [PATCH v3 2/3] arm64: dts: qcom: qcs615: add UFS node Xin Liu
2024-12-02 14:44 ` Manivannan Sadhasivam
2024-12-05 21:21 ` Konrad Dybcio
2024-12-09 7:56 ` Xin Liu
2024-12-12 16:11 ` Konrad Dybcio
2024-11-22 6:44 ` [PATCH v3 3/3] arm64: dts: qcom: qcs615-ride: Enable " Xin Liu
2024-12-02 14:48 ` Manivannan Sadhasivam
2024-12-09 8:31 ` Xin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66654b75-cfc2-470c-90e9-76da5e2a1f47@quicinc.com \
--to=quic_liuxin@quicinc.com \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_jiegan@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox