From: Neil Armstrong <neil.armstrong@linaro.org>
To: Vinod Koul <vkoul@kernel.org>, linux-phy@lists.infradead.org
Cc: Vladimir Oltean <olteanv@gmail.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Subject: Re: [PATCH] phy: qcom: qmp-pcie: drop unused reset names
Date: Wed, 7 Oct 2026 17:46:32 +0200 [thread overview]
Message-ID: <87cbf5d0-e019-4acb-906b-0030043bd518@linaro.org> (raw)
In-Reply-To: <20261003093559.199326-1-vkoul@kernel.org>
On 10/3/26 11:35, Vinod Koul wrote:
> Commit e397c8507e36 ("phy: qcom: qmp-pcie: Add Nord Gen5x16 PCIe
> multi-PHY support") added a bunch of reset names, but also added two
> which are not being used.
>
> This leads to compiler warnings:
> drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c:750:27: error: ‘nord_pciephy_port_b_nocsr_reset_l’ defined but not used [-Werror=unused-const-variable=]
> 750 | static const char * const nord_pciephy_port_b_nocsr_reset_l[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c:746:27: error: ‘nord_pciephy_port_a_nocsr_reset_l’ defined but not used [-Werror=unused-const-variable=]
> 746 | static const char * const nord_pciephy_port_a_nocsr_reset_l[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Drop these
>
> Fixes: e397c8507e36 ("phy: qcom: qmp-pcie: Add Nord Gen5x16 PCIe multi-PHY support")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c | 8 --------
> 1 file changed, 8 deletions(-)
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2026-10-07 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 9:35 [PATCH] phy: qcom: qmp-pcie: drop unused reset names Vinod Koul
2026-10-07 15:46 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cbf5d0-e019-4acb-906b-0030043bd518@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=olteanv@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox