[PATCH] phy: qcom: qmp-pcie: drop unused reset names

[PATCH] phy: qcom: qmp-pcie: drop unused reset names

[Vinod Koul]

Commit e397c8507e36 ("phy: qcom: qmp-pcie: Add Nord Gen5x16 PCIe
multi-PHY support") added a bunch of reset names, but also added two
which are not being used.

This leads to compiler warnings:
drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c:750:27: error: ‘nord_pciephy_port_b_nocsr_reset_l’ defined but not used [-Werror=unused-const-variable=]
  750 | static const char * const nord_pciephy_port_b_nocsr_reset_l[] = {
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c:746:27: error: ‘nord_pciephy_port_a_nocsr_reset_l’ defined but not used [-Werror=unused-const-variable=]
  746 | static const char * const nord_pciephy_port_a_nocsr_reset_l[] = {
      |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Drop these

Fixes: e397c8507e36 ("phy: qcom: qmp-pcie: Add Nord Gen5x16 PCIe multi-PHY support")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c
index f1267691bf32..7bc62a668d34 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c
@@ -743,14 +743,6 @@ static const char * const nord_pciephy_port_abcd_reset_l[] = {
 	"port_a", "port_b", "port_c", "port_d",
 };
 
-static const char * const nord_pciephy_port_a_nocsr_reset_l[] = {
-	"port_a_nocsr",
-};
-
-static const char * const nord_pciephy_port_b_nocsr_reset_l[] = {
-	"port_b_nocsr",
-};
-
 static const char * const nord_pciephy_port_c_nocsr_reset_l[] = {
 	"port_c_nocsr",
 };
-- 
2.53.0


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: qcom: qmp-pcie: drop unused reset names

[Neil Armstrong]

On 10/3/26 11:35, Vinod Koul wrote:
> Commit e397c8507e36 ("phy: qcom: qmp-pcie: Add Nord Gen5x16 PCIe
> multi-PHY support") added a bunch of reset names, but also added two
> which are not being used.
> 
> This leads to compiler warnings:
> drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c:750:27: error: ‘nord_pciephy_port_b_nocsr_reset_l’ defined but not used [-Werror=unused-const-variable=]
>    750 | static const char * const nord_pciephy_port_b_nocsr_reset_l[] = {
>        |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c:746:27: error: ‘nord_pciephy_port_a_nocsr_reset_l’ defined but not used [-Werror=unused-const-variable=]
>    746 | static const char * const nord_pciephy_port_a_nocsr_reset_l[] = {
>        |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Drop these
> 
> Fixes: e397c8507e36 ("phy: qcom: qmp-pcie: Add Nord Gen5x16 PCIe multi-PHY support")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>   drivers/phy/qualcomm/phy-qcom-qmp-pcie-multiphy.c | 8 --------
>   1 file changed, 8 deletions(-)
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy