From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Mrinmay Sarkar <mrinmay.sarkar@oss.qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
krishna.chundru@oss.qualcomm.com, quic_vbadigan@quicinc.com,
quic_nayiluri@quicinc.com, quic_ramkri@quicinc.com,
quic_nitegupt@quicinc.com,
Mrinmay Sarkar <quic_msarkar@quicinc.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sa8775p: Remove max link speed property for PCIe EP
Date: Fri, 30 May 2025 12:56:44 +0200 [thread overview]
Message-ID: <8972adb4-b6ae-4ea9-986a-32e59fe84c50@oss.qualcomm.com> (raw)
In-Reply-To: <41ac26a6-7a5a-4c11-b05c-9ce688ad1856@oss.qualcomm.com>
On 5/30/25 12:50 PM, Konrad Dybcio wrote:
> On 5/30/25 7:38 AM, Mrinmay Sarkar wrote:
>> On Tue, May 27, 2025 at 4:06 PM Konrad Dybcio
>> <konrad.dybcio@oss.qualcomm.com> wrote:
>>>
>>> On 5/25/25 3:29 PM, Dmitry Baryshkov wrote:
>>>> On Sun, May 25, 2025 at 11:27:18AM +0530, Mrinmay Sarkar wrote:
>>>>> From: Mrinmay Sarkar <mrinmay.sarkar@oss.qualcomm.com>
>>>>>
>>>>> The maximum link speed was previously restricted to Gen3 due to the
>>>>> absence of Gen4 equalization support in the driver.
>>>>>
>>>>> Add change to remove max link speed property, Since Gen4 equalization
>>>>> support has already been added into the driver.
>>>>
>>>> As Gen4 equalization is already supported by the XYZ driver remove the
>>>> max-link-speed property.
>>>>
>>>> "Add change to remove" is a bit clumsy.
>>>
>>> I'm more worried about this node not having these gen4 eq settings
>>> (i.e. the part talking about driver support landing is true, but it's
>>> unused without the presets being explicitly defined in eq-presets-16gts)
>>>
>>> Konrad
>>
>> Hi Konrad,
>>
>> Actually stability issue was resolved by this patch series:
>> https://lore.kernel.org/linux-pci/20240911-pci-qcom-gen4-stability-v7-3-743f5c1fd027@linaro.org/
>> and I don't think we need to define eq-presets-16gts for this.
>
> Okay, so there's multiple parts to it..
>
> I was referring to this series
>
> https://lore.kernel.org/all/20250328-preset_v6-v9-0-22cfa0490518@oss.qualcomm.com/
>
> Please check if you need this as well
If not, we can get this merged as-is
Konrad
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-05-30 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-25 5:57 [PATCH v3 0/2] Update PCIe PHY settings for QCS8300 and SA8775P Mrinmay Sarkar
2025-05-25 5:57 ` [PATCH v3 1/2] phy: qcom: qmp-pcie: Update PHY settings for QCS8300 & SA8775P Mrinmay Sarkar
2025-05-25 5:57 ` [PATCH v3 2/2] arm64: dts: qcom: sa8775p: Remove max link speed property for PCIe EP Mrinmay Sarkar
2025-05-25 13:29 ` Dmitry Baryshkov
2025-05-27 10:36 ` Konrad Dybcio
2025-05-30 5:38 ` Mrinmay Sarkar
2025-05-30 10:50 ` Konrad Dybcio
2025-05-30 10:56 ` Konrad Dybcio [this message]
2025-06-04 6:34 ` Mrinmay Sarkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8972adb4-b6ae-4ea9-986a-32e59fe84c50@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mrinmay.sarkar@oss.qualcomm.com \
--cc=quic_msarkar@quicinc.com \
--cc=quic_nayiluri@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox