public inbox for linux-phy@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH -next] phy: intel: Remove redundant dev_err call in thunderbay_emmc_phy_probe()
@ 2021-11-25  6:38 Zou Wei
  2021-12-02  4:16 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-11-25  6:38 UTC (permalink / raw)
  To: nandhini.srikandan, rashmi.a, kishon, vkoul
  Cc: linux-phy, linux-kernel, Zou Wei

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/phy/intel/phy-intel-thunderbay-emmc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/phy/intel/phy-intel-thunderbay-emmc.c b/drivers/phy/intel/phy-intel-thunderbay-emmc.c
index 2d6ea84..593f697 100644
--- a/drivers/phy/intel/phy-intel-thunderbay-emmc.c
+++ b/drivers/phy/intel/phy-intel-thunderbay-emmc.c
@@ -472,10 +472,8 @@ static int thunderbay_emmc_phy_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	tbh_phy->reg_base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(tbh_phy->reg_base)) {
-		dev_err(&pdev->dev, "region map failed\n");
+	if (IS_ERR(tbh_phy->reg_base))
 		return PTR_ERR(tbh_phy->reg_base);
-	}
 
 	tbh_phy->phy_power_sts = PHY_UNINITIALIZED;
 	id = of_match_node(thunderbay_emmc_phy_of_match, pdev->dev.of_node);
-- 
2.6.2


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] phy: intel: Remove redundant dev_err call in thunderbay_emmc_phy_probe()
  2021-11-25  6:38 [PATCH -next] phy: intel: Remove redundant dev_err call in thunderbay_emmc_phy_probe() Zou Wei
@ 2021-12-02  4:16 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2021-12-02  4:16 UTC (permalink / raw)
  To: Zou Wei; +Cc: nandhini.srikandan, rashmi.a, kishon, linux-phy, linux-kernel

On 25-11-21, 14:38, Zou Wei wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied, thanks

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-02  4:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-25  6:38 [PATCH -next] phy: intel: Remove redundant dev_err call in thunderbay_emmc_phy_probe() Zou Wei
2021-12-02  4:16 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox