From: Vinod Koul <vkoul@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Kishon Vijay Abraham I" <kishon@ti.com>,
"Al Cooper" <alcooperx@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-phy@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] phy: phy-brcm-usb: fixup BCM4908 support
Date: Fri, 25 Feb 2022 14:32:46 +0530 [thread overview]
Message-ID: <YhibNvLHtna59t/i@matsya> (raw)
In-Reply-To: <20220218172459.10431-1-zajec5@gmail.com>
On 18-02-22, 18:24, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Just like every other family BCM4908 should get its own enum value. That
> is required to properly handle it in chipset conditional code.
>
> The real change is excluding BCM4908 from the PLL reprogramming code
> (see brcmusb_usb3_pll_54mhz()). I'm not sure what's the BCM4908
> reference clock frequency but:
> 1. BCM4908 custom driver from Broadcom's SDK doesn't reprogram PLL
> 2. Doing that in Linux driver stopped PHY handling some USB 3.0 devices
>
> This change makes USB 3.0 PHY recognize e.g.:
> 1. 04e8:6860 - Samsung Electronics Co., Ltd Galaxy series, misc. (MTP mode)
> 2. 1058:259f - Western Digital My Passport 259F
>
> Broadcom's STB SoCs come with a set of SUN_TOP_CTRL_* registers that
> allow reading chip family and product ids. Such a block & register is
> missing on BCM4908 so this commit introduces "compatible" string
> specific binding.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2022-02-25 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 17:24 [PATCH] phy: phy-brcm-usb: fixup BCM4908 support Rafał Miłecki
2022-02-25 0:50 ` Florian Fainelli
2022-02-25 9:02 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhibNvLHtna59t/i@matsya \
--to=vkoul@kernel.org \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox