From: Vinod Koul <vkoul@kernel.org>
To: Minda Chen <minda.chen@starfivetech.com>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,
linux-phy@lists.infradead.org, Roger Quadros <rogerq@kernel.org>,
Changhuang Liang <changhuang.liang@starfivetech.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] phy: starfive: make phys depend on HAS_IOMEM
Date: Tue, 25 Jul 2023 12:07:22 +0530 [thread overview]
Message-ID: <ZL9toiRzky+Lz0fF@matsya> (raw)
In-Reply-To: <f09f3229-96ba-67a8-ccf1-e2184006c979@starfivetech.com>
On 25-07-23, 14:27, Minda Chen wrote:
>
>
> On 2023/7/25 14:22, Vinod Koul wrote:
> > the startfive phy drivers use devm_platform_ioremap_resource() which on
> > some archs (s390) is not present. So make the drivers depend on HAS_IOMEM
> >
> > Fixes: f8aa660841bc ("phy: starfive: Add mipi dphy rx support")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202307250509.oeudxG28-lkp@intel.com/
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > drivers/phy/starfive/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
> > index a560533a674e..ea82261ca818 100644
> > --- a/drivers/phy/starfive/Kconfig
> > +++ b/drivers/phy/starfive/Kconfig
> > @@ -5,6 +5,7 @@
> >
> > config PHY_STARFIVE_JH7110_DPHY_RX
> > tristate "StarFive JH7110 D-PHY RX support"
> > + depends on HAS_IOMEM
> > select GENERIC_PHY
> > select GENERIC_PHY_MIPI_DPHY
> > help
> > @@ -24,7 +25,7 @@ config PHY_STARFIVE_JH7110_PCIE
> >
> > config PHY_STARFIVE_JH7110_USB
> > tristate "Starfive JH7110 USB 2.0 PHY support"
> > - depends on USB_SUPPORT
> > + depends on USB_SUPPORT && HAS_IOMEM
> > select GENERIC_PHY
> > help
> > Enable this to support the StarFive USB 2.0 PHY,
> Hi Vinod
>
> The USB_SUPPORT already depends on HAS_IOMEM.
>
> menuconfig USB_SUPPORT
> bool "USB support"
> depends on HAS_IOMEM
> default y
Yes I will drop the second part of the patch, will post v2 shortly
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2023-07-25 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 6:22 [PATCH] phy: starfive: make phys depend on HAS_IOMEM Vinod Koul
2023-07-25 6:27 ` Minda Chen
2023-07-25 6:37 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL9toiRzky+Lz0fF@matsya \
--to=vkoul@kernel.org \
--cc=changhuang.liang@starfivetech.com \
--cc=kishon@kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lkp@intel.com \
--cc=minda.chen@starfivetech.com \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox