* [PATCH] phy: starfive: make phys depend on HAS_IOMEM
@ 2023-07-25 6:22 Vinod Koul
2023-07-25 6:27 ` Minda Chen
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2023-07-25 6:22 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul
Cc: linux-phy, Minda Chen, Roger Quadros, Changhuang Liang,
kernel test robot
the startfive phy drivers use devm_platform_ioremap_resource() which on
some archs (s390) is not present. So make the drivers depend on HAS_IOMEM
Fixes: f8aa660841bc ("phy: starfive: Add mipi dphy rx support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307250509.oeudxG28-lkp@intel.com/
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/phy/starfive/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
index a560533a674e..ea82261ca818 100644
--- a/drivers/phy/starfive/Kconfig
+++ b/drivers/phy/starfive/Kconfig
@@ -5,6 +5,7 @@
config PHY_STARFIVE_JH7110_DPHY_RX
tristate "StarFive JH7110 D-PHY RX support"
+ depends on HAS_IOMEM
select GENERIC_PHY
select GENERIC_PHY_MIPI_DPHY
help
@@ -24,7 +25,7 @@ config PHY_STARFIVE_JH7110_PCIE
config PHY_STARFIVE_JH7110_USB
tristate "Starfive JH7110 USB 2.0 PHY support"
- depends on USB_SUPPORT
+ depends on USB_SUPPORT && HAS_IOMEM
select GENERIC_PHY
help
Enable this to support the StarFive USB 2.0 PHY,
--
2.41.0
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: starfive: make phys depend on HAS_IOMEM
2023-07-25 6:22 [PATCH] phy: starfive: make phys depend on HAS_IOMEM Vinod Koul
@ 2023-07-25 6:27 ` Minda Chen
2023-07-25 6:37 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Minda Chen @ 2023-07-25 6:27 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I
Cc: linux-phy, Roger Quadros, Changhuang Liang, kernel test robot
On 2023/7/25 14:22, Vinod Koul wrote:
> the startfive phy drivers use devm_platform_ioremap_resource() which on
> some archs (s390) is not present. So make the drivers depend on HAS_IOMEM
>
> Fixes: f8aa660841bc ("phy: starfive: Add mipi dphy rx support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307250509.oeudxG28-lkp@intel.com/
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/phy/starfive/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
> index a560533a674e..ea82261ca818 100644
> --- a/drivers/phy/starfive/Kconfig
> +++ b/drivers/phy/starfive/Kconfig
> @@ -5,6 +5,7 @@
>
> config PHY_STARFIVE_JH7110_DPHY_RX
> tristate "StarFive JH7110 D-PHY RX support"
> + depends on HAS_IOMEM
> select GENERIC_PHY
> select GENERIC_PHY_MIPI_DPHY
> help
> @@ -24,7 +25,7 @@ config PHY_STARFIVE_JH7110_PCIE
>
> config PHY_STARFIVE_JH7110_USB
> tristate "Starfive JH7110 USB 2.0 PHY support"
> - depends on USB_SUPPORT
> + depends on USB_SUPPORT && HAS_IOMEM
> select GENERIC_PHY
> help
> Enable this to support the StarFive USB 2.0 PHY,
Hi Vinod
The USB_SUPPORT already depends on HAS_IOMEM.
menuconfig USB_SUPPORT
bool "USB support"
depends on HAS_IOMEM
default y
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: starfive: make phys depend on HAS_IOMEM
2023-07-25 6:27 ` Minda Chen
@ 2023-07-25 6:37 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-07-25 6:37 UTC (permalink / raw)
To: Minda Chen
Cc: Kishon Vijay Abraham I, linux-phy, Roger Quadros,
Changhuang Liang, kernel test robot
On 25-07-23, 14:27, Minda Chen wrote:
>
>
> On 2023/7/25 14:22, Vinod Koul wrote:
> > the startfive phy drivers use devm_platform_ioremap_resource() which on
> > some archs (s390) is not present. So make the drivers depend on HAS_IOMEM
> >
> > Fixes: f8aa660841bc ("phy: starfive: Add mipi dphy rx support")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202307250509.oeudxG28-lkp@intel.com/
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > drivers/phy/starfive/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
> > index a560533a674e..ea82261ca818 100644
> > --- a/drivers/phy/starfive/Kconfig
> > +++ b/drivers/phy/starfive/Kconfig
> > @@ -5,6 +5,7 @@
> >
> > config PHY_STARFIVE_JH7110_DPHY_RX
> > tristate "StarFive JH7110 D-PHY RX support"
> > + depends on HAS_IOMEM
> > select GENERIC_PHY
> > select GENERIC_PHY_MIPI_DPHY
> > help
> > @@ -24,7 +25,7 @@ config PHY_STARFIVE_JH7110_PCIE
> >
> > config PHY_STARFIVE_JH7110_USB
> > tristate "Starfive JH7110 USB 2.0 PHY support"
> > - depends on USB_SUPPORT
> > + depends on USB_SUPPORT && HAS_IOMEM
> > select GENERIC_PHY
> > help
> > Enable this to support the StarFive USB 2.0 PHY,
> Hi Vinod
>
> The USB_SUPPORT already depends on HAS_IOMEM.
>
> menuconfig USB_SUPPORT
> bool "USB support"
> depends on HAS_IOMEM
> default y
Yes I will drop the second part of the patch, will post v2 shortly
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-25 6:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 6:22 [PATCH] phy: starfive: make phys depend on HAS_IOMEM Vinod Koul
2023-07-25 6:27 ` Minda Chen
2023-07-25 6:37 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox