From: Vinod Koul <vkoul@kernel.org>
To: Michael Dege <michael.dege@renesas.com>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Uwe Kleine-Koenig <u.kleine-koenig@baylibre.com>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/2 RESEND] phy: renesas: r8a779f0-ether-serdes: driver enhancement
Date: Fri, 27 Jun 2025 11:48:38 -0700 [thread overview]
Message-ID: <aF7nhuFWdp80sZTS@vaman> (raw)
In-Reply-To: <TY4PR01MB142825081D5279CA2D8251EBE8245A@TY4PR01MB14282.jpnprd01.prod.outlook.com>
Hi Michael,
On 27-06-25, 04:52, Michael Dege wrote:
> > > This patch set adds the following to the r8a779f0-ether-serdes driver:
> >
> > I have a v3 and v3 resend and both are not threaded properly, Please post properly as a series which
> > is threaded and not broken...
>
> Please bear with me this is the first attempt to upstream a patch. I used b4 to produce and send this
> patch series. I did have trouble when I tried to use b4 to resend. And ended up using "git send-email"
> to resend.
> I don't quite understand what you mean by threaded and what is broken. Could you please give
> me a hint what is wrong? I am willing to learn and would like to get it right.
See Documentation/process/5.Posting.rst
"In general, the second and following parts of a multi-part patch should be
sent as a reply to the first part so that they all thread together at the
receiving end. Tools like git and quilt have commands to mail out a set of
patches with the proper threading. "
For me, patch 1,2 and cover letter appear as disjoint so hard to
review the patches when they are split in my inbox.
A patch series if threaded, would appear together so easy to look at it.
Said that, if you are using git send-email, easiest way is to supply the
whole patch series to it and not per patch basis
For example:
git send-email ....../dir_of_patches/
would ensure they are threaded and sent together
HTH
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2025-06-27 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 8:17 [PATCH v3 0/2 RESEND] phy: renesas: r8a779f0-ether-serdes: driver enhancement Michael Dege
2025-06-26 22:58 ` Vinod Koul
2025-06-27 4:52 ` Michael Dege
2025-06-27 18:48 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF7nhuFWdp80sZTS@vaman \
--to=vkoul@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=michael.dege@renesas.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox