Re: [PATCH v2 1/3] phy: exynos5-usbdrd: power the Exynos2200 phy down when its init fails

[Vinod Koul <vkoul@kernel.org>]

On 11-11-26, 03:32, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] phy: exynos5-usbdrd: single-word name in Signed-off-by and
>   Author trailers

This is important, please provide full name as required by DCO

> --
> 
> commit ea360718642a10fc523396c37cb054fd6d6668fb
> Author: Soheyb <soheyb_boulaa@proton.me>
> 
> > phy: exynos5-usbdrd: power the Exynos2200 phy down when its init fails
> >
> > exynos2200_usbdrd_phy_init() enables the regulators of the UTMI phy and
> > takes the phy out of isolation in the PMU before it enables the clocks.
> > When clk_bulk_prepare_enable() fails, it returns without undoing
> > either. The phy core does not count a failed init, so no exit undoes
> > them later: the phy stays out of isolation, and its supplies stay
> > enabled, until an init and an exit succeed.
> >
> > Isolate the phy again and disable the UTMI regulators when the clocks
> > or the phy-specific init fail. The phy-specific init does not fail yet;
> > the next patch makes the UTMI init return the result of the init of the
> > high-speed phy.
> >
> > Fixes: cc52a697f87e ("phy: exynos5-usbdrd: support Exynos USBDRD 3.2 4nm controller")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Soheyb <soheyb_boulaa@proton.me>
> 
> [Severity: High]
> Could the Author header and Signed-off-by tag use a full real name (for
> example, Soheyb Boulaa) instead of a single-word name, as required by
> Documentation/process/submitting-patches.rst for the Developer's
> Certificate of Origin?
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20261111032309.3365794-1-soheyb_boulaa@proton.me?part=1

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy