From: Krzysztof Kozlowski <krzk@kernel.org>
To: Diederik de Haas <didi.debian@cknow.org>,
Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] dt-bindings: phy: add samsung,exynos2200-snps-eusb2-phy schema file
Date: Sun, 16 Feb 2025 10:22:58 +0100 [thread overview]
Message-ID: <fc860290-c5e5-4193-a8b7-a53137dd4155@kernel.org> (raw)
In-Reply-To: <D7TR7VP9UPQA.2U5BL328HNSXU@cknow.org>
On 16/02/2025 10:14, Diederik de Haas wrote:
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/samsung,exynos2200.h>
>> +
>> + usb_hsphy: phy@10ab0000 {
>> + compatible = "samsung,exynos2200-snps-eusb2-phy";
>> + reg = <0 0x10ab0000 0 0x10000>;
>> + clocks = <&cmu_hsi0 CLK_MOUT_HSI0_USB32DRD>,
>> + <&cmu_hsi0 CLK_MOUT_HSI0_NOC>,
>> + <&cmu_hsi0 CLK_DOUT_DIV_CLK_HSI0_EUSB>;
>> + clock-names = "ref", "apb", "ctrl";
>> + #phy-cells = <0>;
>> + phys = <&usbcon_phy>;
>> + };
>
> Shouldn't the example have at least all the *required* properties?
> Same for patch 2 of this series.
Yeah, this wasn't ever tested.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-02-16 9:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-15 12:24 [PATCH v1 0/4] phy: samsung: add Exynos2200 SNPS eUSB2 driver Ivaylo Ivanov
2025-02-15 12:24 ` [PATCH v1 1/4] dt-bindings: phy: add samsung,exynos2200-snps-eusb2-phy schema file Ivaylo Ivanov
2025-02-15 13:29 ` Rob Herring (Arm)
2025-02-16 9:14 ` Diederik de Haas
2025-02-16 9:22 ` Krzysztof Kozlowski [this message]
2025-02-16 9:27 ` Ivaylo Ivanov
2025-02-16 9:37 ` Krzysztof Kozlowski
2025-02-15 12:24 ` [PATCH v1 2/4] dt-bindings: phy: add samsung,exynos2200-usbcon-phy " Ivaylo Ivanov
2025-02-15 13:29 ` Rob Herring (Arm)
2025-02-15 12:24 ` [PATCH v1 3/4] phy: samsung: add Exynos2200 SNPS eUSB2 driver Ivaylo Ivanov
2025-02-16 9:26 ` Krzysztof Kozlowski
2025-02-16 9:41 ` Ivaylo Ivanov
2025-02-16 9:44 ` Krzysztof Kozlowski
2025-02-16 9:51 ` Ivaylo Ivanov
2025-02-16 13:19 ` Krzysztof Kozlowski
2025-02-16 13:57 ` Ivaylo Ivanov
2025-02-16 18:25 ` Ivaylo Ivanov
2025-02-17 9:05 ` Philipp Zabel
2025-02-15 12:24 ` [PATCH v1 4/4] phy: samsung: add Exynos2200 usb phy controller Ivaylo Ivanov
2025-02-16 9:36 ` Krzysztof Kozlowski
2025-02-16 9:58 ` Ivaylo Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc860290-c5e5-4193-a8b7-a53137dd4155@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox