Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] phy: Add the Siflower SF19A2890 USB 2.0 PHY
@ 2026-11-17  0:31 Joseph Telaak via B4 Relay
  2026-11-17  0:31 ` [PATCH v2 1/2] dt-bindings: phy: Add " Joseph Telaak via B4 Relay
  2026-11-17  0:31 ` [PATCH v2 2/2] phy: siflower: Add SF19A2890 USB 2.0 PHY driver Joseph Telaak via B4 Relay
  0 siblings, 2 replies; 4+ messages in thread
From: Joseph Telaak via B4 Relay @ 2026-11-17  0:31 UTC (permalink / raw)
  To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Philipp Zabel
  Cc: Chuanhong Guo, linux-mips, linux-phy, devicetree, linux-kernel,
	Conor Dooley, Joseph Telaak

This series adds a binding and a driver for the USB 2.0 PHY of the
Siflower SF19A2890, a MIPS SoC for home routers. The PHY takes its
reference clock and its two resets from the USB block's clock and reset
manager, which goes to the clk tree.

The driver is Chuanhong Guo's, from his SF19A2890 branch [1], with my
changes noted.

The SoC support itself (MACH_SIFLOWER_MIPS) goes through the MIPS tree;
until then the driver builds with COMPILE_TEST. The DWC2 part goes to
the USB tree.

Tested on a GL.iNet GL-SFT1200 with the DWC2 patches. With v1 on
v7.4-rc1, a USB stick enumerates at 480 Mb/s and reads at 5.6 MB/s
(5.0 MB/s with the same stick on OpenWrt's 6.18 kernel), and comes back
after unplugging and replugging it twice. v2 takes the resets with the
bulk API, so it was run again, on OpenWrt's 6.18 kernel with the driver
backported: the stick enumerates at 480 Mb/s after a cold and a warm
boot and after reloading dwc2, which powers the PHY off and on, and
comes back after a replug.

[1] https://github.com/981213/linux/commits/siflower-7.1

---
Changes in v2:
- Write my note on Chuanhong's patch as a list.
- Add a MAINTAINERS entry for the driver and its binding, naming the
  driver's file, since drivers/phy/siflower/ will also hold the SF21
  PHY drivers.
- Get and toggle both resets with the reset_control_bulk API (Philipp).
- Word the error messages the same way, name the error labels, include
  <linux/device-id/of.h> instead of <linux/of.h>, and use GPL-2.0-only,
  not the deprecated GPL-2.0 SPDX identifier.
- Patch 1: add Conor's Ack.
- Link to v1: https://patch.msgid.link/20261104-sf19a2890-usb-phy-v1-0-db0cad937614@telaak.dev

---
Chuanhong Guo (1):
      phy: siflower: Add SF19A2890 USB 2.0 PHY driver

Joseph Telaak (1):
      dt-bindings: phy: Add Siflower SF19A2890 USB 2.0 PHY

 .../bindings/phy/siflower,sf19a2890-usb-phy.yaml   |  58 +++++++++
 MAINTAINERS                                        |   7 ++
 drivers/phy/Kconfig                                |   1 +
 drivers/phy/Makefile                               |   1 +
 drivers/phy/siflower/Kconfig                       |  12 ++
 drivers/phy/siflower/Makefile                      |   2 +
 drivers/phy/siflower/phy-sf19a2890-usb.c           | 132 +++++++++++++++++++++
 7 files changed, 213 insertions(+)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261102-sf19a2890-usb-phy-5bb644992750

Best regards,
--  
Joseph Telaak <joseph@telaak.dev>



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-17  0:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17  0:31 [PATCH v2 0/2] phy: Add the Siflower SF19A2890 USB 2.0 PHY Joseph Telaak via B4 Relay
2026-11-17  0:31 ` [PATCH v2 1/2] dt-bindings: phy: Add " Joseph Telaak via B4 Relay
2026-11-17  0:31 ` [PATCH v2 2/2] phy: siflower: Add SF19A2890 USB 2.0 PHY driver Joseph Telaak via B4 Relay
2026-11-17  0:53   ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox